fix: do not map root to ambiguous endpoint, opt-in with compat flag #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
changed the title
This was referenced Mar 27, 2021
This was referenced Mar 28, 2021
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we no longer blindly map root endpoint reports to the first supporting endpoint. Unless the mapping is unambiguous, there's a good chance we'd get it wrong otherwise.
Instead, we now check if there's exactly one endpoint which supports the received CC. If so, the report gets mapped, otherwise it stays on the root endpoint. We can then go on a case-by-case basis and decide for which devices this report is actually needed and the root values need to be preserved.
Also, the new compat option
mapRootReportsToEndpointsnow determines if we even attempt mapping the report at all.fixes: #2155
closes: #2156