Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(config): disallow leading zeroes in firmware versions #1568

Merged
merged 1 commit into from
Feb 3, 2021
Merged

chore(config): disallow leading zeroes in firmware versions #1568

merged 1 commit into from
Feb 3, 2021

Conversation

AlCalzone
Copy link
Member

robertsLando
robertsLando approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW do you have some units test for config files linting?

@AlCalzone
Copy link
Member Author

Uh you mean tests for the tests? No 😅 I test those changes by hand.

@robertsLando
Copy link
Member

Uh you mean tests for the tests? No sweat_smile I test those changes by hand.

I mean something like creating a ConfigValidator.ts where you place all the validation functions (each one could return true if valid or an error string if not) so you can write units test for them. Just a thought btw :)

@AlCalzone
Copy link
Member Author

Accepting PRs 😁

@AlCalzone AlCalzone merged commit fc4e9b1 into master Feb 3, 2021
@AlCalzone AlCalzone deleted the docs/firmware-leading-zero branch February 3, 2021 16:03
blhoward2 pushed a commit to blhoward2/node-zwave-js that referenced this pull request Feb 12, 2021
@AlCalzone @blhoward2
chore(config): disallow leading zeroes in firmware versions (zwave-js…
8aa3f32 
…#1568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlCalzone @robertsLando