Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow and handle response timeouts for GET-type CC commands #1505

Merged
merged 36 commits into from
Jan 27, 2021
Merged

feat: allow and handle response timeouts for GET-type CC commands #1505

merged 36 commits into from
Jan 27, 2021

Conversation

AlCalzone
Copy link
Member

@AlCalzone AlCalzone commented Jan 26, 2021 •
edited
Loading

This PR paves the way for a more permissive handling of missing node responses. Based on the discussion in #1415, we have to expect a timeout for every GET-type CC command and we have to handle it in a way that a missing response does not break everything (e.g. abort and restart interviews for uncritical queries).

As a side-effect the code that previously used ignoreTimeout is more readable now.

closes: #1305
fixes: #1369

@AlCalzone
feat(driver): do not throw when a node response times out
184ad77
@AlCalzone
fix(driver): supervision might not return a response
011af19
@AlCalzone
refactor: change CC APIs to include undefined in the return type
b5a63aa
@AlCalzone
fix(cc): deal with missing reports in MCA CC
8822582
@AlCalzone
fix(cc): deal with missing reports in User Code CC
0b9b058
@AlCalzone
fix(cc): deal with missing reports in Thermostat Setpoint CC
88c969b
@AlCalzone
fix(cc): deal with missing reports in Thermostat Setback CC
a8c10c5
@AlCalzone
fix(cc): deal with missing reports in Thermostat Operating State CC
e1a7a93
@AlCalzone
fix(cc): deal with missing reports in Thermostat Mode CC
7cda91e
@AlCalzone
fix(cc): deal with missing reports in Sound Switch CC
0e9602f
@AlCalzone
fix(cc): deal with missing reports in Protection CC
a80ced6
@AlCalzone
fix(cc): deal with missing reports in Multilevel Sensor CC
3004505
@AlCalzone
fix(cc): deal with missing reports in Meter CC
fb12819
@AlCalzone
fix(cc): deal with missing reports in Language CC
e35d3d2
@AlCalzone
fix(cc): deal with missing reports in Indicator CC
1aa36c3
@AlCalzone
fix(cc): deal with missing reports in Door Lock CC
af290c1
@AlCalzone
fix(cc): deal with missing reports in Configuration CC
edf70f5
@AlCalzone
fix(cc): deal with missing reports in Color Switch CC
c2d216d
@AlCalzone
fix(cc): deal with missing reports in Multilevel Switch CC
c7a38d6
@AlCalzone
fix(cc): deal with missing reports in Binary Switch CC
9f482ef
@AlCalzone
fix(cc): deal with missing reports in Battery CC
dd8502a
@AlCalzone
fix(cc): deal with missing reports in Binary Sensor CC
bef97b4
@AlCalzone
fix(cc): deal with missing reports in Z-Wave+ CC
3d98eec
@AlCalzone
fix(cc): deal with missing reports in Wake Up CC
855a787
@AlCalzone
fix(cc): deal with missing reports in Security CC
d86846c
@AlCalzone
fix(cc): deal with missing reports in Version CC
a619f73
@AlCalzone
fix(cc): deal with missing reports in Notification CC
486f8a6
@AlCalzone
fix(cc): deal with missing reports in Multi Channel CC
c73f5a8
@AlCalzone
fix(cc): deal with missing reports in Manufacturer Specific CC
0a50d43
@AlCalzone
fix(cc): deal with missing reports in Clock CC
4285695
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

1 similar comment
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@AlCalzone AlCalzone marked this pull request as ready for review January 27, 2021 10:21
@AlCalzone
Copy link
Member Author

@zwave-js-bot pack this

@zwave-js-bot
Copy link
Collaborator

👋 Hey @AlCalzone!
I've started to deploy this PR as a development build.
You can monitor the progress here.

@AlCalzone AlCalzone mentioned this pull request Jan 27, 2021
Closed
10 tasks
@zwave-js-bot
Copy link
Collaborator

🎉 The packages have been published.
You can now install the test version with npm install [email protected].

@AlCalzone AlCalzone changed the title feat: for every GET-type CC command, a timeout has to be expected feat: allow and handle response timeouts for GET-type CC commands Jan 27, 2021
@AlCalzone AlCalzone mentioned this pull request Jan 27, 2021
Closed
@AlCalzone AlCalzone merged commit c2429bf into master Jan 27, 2021
@AlCalzone AlCalzone deleted the cc-no-response branch January 27, 2021 22:55
blhoward2 pushed a commit to blhoward2/node-zwave-js that referenced this pull request Feb 12, 2021
@AlCalzone @blhoward2
feat: allow and handle response timeouts for GET-type CC commands (zw…
cd8a79d 
…ave-js#1505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Aeotec Smart Switch 6 - Fails to complete Interview
2 participants
@AlCalzone @zwave-js-bot