fix: consistency, version range, filename

zwave-js · Oct 11, 2023 · bb5a5e6 · bb5a5e6
1 parent ed5592b
commit bb5a5e6
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 21 deletions.
diff --git a/.../config/config/devices/0x0148/cometz.json → ...fig/config/devices/0x0148/cometz_500.json b/.../config/config/devices/0x0148/cometz.json → ...fig/config/devices/0x0148/cometz_500.json
@@ -1,10 +1,11 @@
 {
 	"manufacturer": "Eurotronics",
 	"manufacturerId": "0x0148",
-	"label": "COMET Z",
+	"label": "Comet Z",
 	"description": "Thermostatic Valve",
 	"devices": [
 		{
+			// 500 series
 			"productType": "0x0002",
 			"productId": "0x0001",
 			"zwaveAllianceId": [1601, 2200, 2201, 2202]

diff --git a/...g/config/devices/0x0148/comet_z_11.0.json → ...fig/config/devices/0x0148/cometz_700.json b/...g/config/devices/0x0148/comet_z_11.0.json → ...fig/config/devices/0x0148/cometz_700.json
@@ -2,15 +2,16 @@
 	"manufacturer": "Eurotronics",
 	"manufacturerId": "0x0148",
 	"label": "Comet Z",
-	"description": "HVAC- Radiator Controller",
+	"description": "Radiator Thermostat",
 	"devices": [
 		{
+			// 700 series
 			"productType": "0x0004",
 			"productId": "0x0003"
 		}
 	],
 	"firmwareVersion": {
-		"min": "11.0",
+		"min": "0.0",
 		"max": "255.255"
 	},
 	"associations": {
@@ -23,8 +24,10 @@
 	"paramInformation": [
 		{
 			"#": "1",
-			"$import": "~/templates/master_template.json#base_enable_disable",
-			"label": "LCD invert",
+			"label": "Invert LCD",
+			"valueSize": 1,
+			"defaultValue": 0,
+			"allowManualEntry": false,
 			"options": [
 				{
 					"label": "Normal",
@@ -47,60 +50,73 @@
 		},
 		{
 			"#": "4",
-			"$import": "~/templates/master_template.json#base_enable_disable",
 			"label": "Battery Status Reporting",
+			"valueSize": 1,
+			"defaultValue": 0,
+			"allowManualEntry": false,
 			"options": [
 				{
-					"label": "event controlled",
+					"label": "Event-Controlled",
 					"value": 0
 				},
 				{
-					"label": "once a day",
+					"label": "Daily",
 					"value": 1
 				}
 			]
 		},
 		{
 			"#": "5",
 			"label": "Actual-Temperature Reporting",
-			"description": "0: Disabled; 1-50 = 0.1°C - 5.0°C",
 			"valueSize": 1,
-			"minValue": 1,
+			"unit": "0.1 °C",
+			"minValue": 0,
 			"maxValue": 50,
-			"defaultValue": 5
+			"defaultValue": 5,
+			"options": [
+				{
+					"label": "Disabled",
+					"value": 0
+				}
+			]
 		},
 		{
 			"#": "7",
-			"label": "Window-open Detection",
-			"description": "0 = Deactivated",
+			"label": "Open Window Detection",
 			"valueSize": 1,
 			"minValue": 0,
 			"maxValue": 3,
 			"defaultValue": 1,
 			"options": [
 				{
-					"label": "low sensitivity",
+					"label": "Disabled",
+					"value": 0
+				},
+				{
+					"label": "Low sensitivity",
 					"value": 1
 				},
 				{
-					"label": "medium sensitivity",
+					"label": "Medium sensitivity",
 					"value": 2
 				},
 				{
-					"label": "high sensitivity",
+					"label": "High sensitivity",
 					"value": 3
 				}
 			]
 		},
 		{
 			"#": "8",
-			"label": "Actual-Temperature- Offset",
-			"description": "Value = Parameter * 0.1°C",
+			"label": "Temperature Calibration",
 			"valueSize": 1,
+			"unit": "0.1 °C",
 			"minValue": -50,
 			"maxValue": 50,
-			"defaultValue": 0,
-			"unsigned": false
+			"defaultValue": 0
 		}
-	]
+	],
+	"metadata": {
+		"manual": "https://eurotronic.org/wp-content/uploads/2023/04/Comet-Z-Wave-EN-2023-04-06.pdf"
+	}
 }