Refactor isDuplicated type #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Committed a fix for the eslint error. |
|
Hi, thanks for trying it out. I added some more tests. |
|
Thank you, I will take another look within the week, otherwise I will close the pull request. |
- Simplify logic to check if present in array - Renamed type to isInArray - Integrated type in HasDuplicatedNames
- Accepts an array of previous slice configs, following the recursion in HasDuplicatedNames, along with the current one - Utilize Extract util to check for name collisions, as well as InferState and new InferStateNames types
grigorischristainas
force-pushed
the
main
branch
from
5fa1d9c to
97631da
Compare
|
Gave it another try, just noticed another similar PR open that seems simpler :) Please feel free to close this one. |
|
Yeah, thanks for trying anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, nice project!
I open this pull request to refactor
isDuplicatedtype, as I noticed that it is in fact used withinHasDuplicatedNamesto check for the presence of aNameinNames.Hope I did not misunderstand its usage and that I am not breaking any additional functionality, but please let me know if any additional changes are required.