Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update example to prevent action name collision #29

Conversation

unbeauvoyage
Copy link
Contributor

In the getting started section example, two actions have the same name, which will result in text action not working. This PR renames them to prevent collision and probable confusion.

In the getting started section example, two actions have the same name, which will result in text action not working. This PR renames them to prevent collision and probable confusion.
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Member

dai-shi commented Sep 27, 2024

It's intentional to have the same action name. Both actions should be called.

which will result in text action not working.

Can you try it again? If it's not working, it can be a bug.

@unbeauvoyage
Copy link
Contributor Author

unbeauvoyage commented Sep 27, 2024

@dai-shi
I tried it again, and as you said it does reset both. (The first time over I had mistakenly expected text to be set to empty string and not to its default "hello" value). Thanks for responding, I'm closing this, as the code works just fine.

Resets to "hello" and 0 at the same time, as intended:
image

@dai-shi
Copy link
Member

dai-shi commented Sep 27, 2024

Good.

On the other hand, this "action merging" behavior is one of features of this fairly opinionated lib, so it should be clearly stated somewhere.

@unbeauvoyage unbeauvoyage deleted the update-example-in-getting-started branch September 27, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants