use Maps to only iterate through slices that actually have a given action #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
out of curiosity, is calling |
|
wow, nice! thanks for working on it. right, calling |
|
sure - do you want a separate PR for tests or should I just add them to this one? |
|
opened #3 with tests |
dai-shi
approved these changes
Apr 21, 2024
| for (const [actionName, actionFn] of Object.entries(config.actions)) { | ||
| let actionsBySlice = sliceMapsByAction.get(actionName); | ||
| if (!actionsBySlice) { | ||
| sliceMapsByAction.set(actionName, (actionsBySlice = new Map())); |
There was a problem hiding this comment.
Oh, I like this syntax. I think I used two statements before for this pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i saw a FIXME and got an itch
there isn't really a test suite yet as far as i can tell, but i tried it out with the example and it still worked correctly