Refactor: change pm_with to pm-with #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zulipbot add "PR needs review" |
Subhasish-Behera
force-pushed
the
pm-with_operator3
branch
from
9c3d4ef
to
6f21034
Compare
The latter form has officially been the narrow format, but the server was previously looser in also accepting the underscore version - though that was subsequently reverted. For details see (on chat.zulip.org): - #zulip-terminal > Cannot narrow to `pm_with` (#T1352) - #api design > direct message search operators Tests adapted. Commit text updated and commits squashed together by neiljp (all changes are necessary together to keep ZT functioning)
neiljp
force-pushed
the
pm-with_operator3
branch
from
6f21034
to
7b5d080
Compare
|
Hello @Subhasish-Behera, it seems like you have referenced #1351 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit: To learn how to write a great commit message, please refer to our guide. |
neiljp
added
PR ready to be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1351
Tested?
Commit flow
This is divided into 3 commits.
model.pyhelper.pymessages.pyCommits are independent of each other
With these changes, the user_list and the
ztoggle on messages work as earlier.Notes & Questions
Interactions
Visual changes