Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable configurable background transparency support #513

Closed
neiljp opened this issue Feb 24, 2020 · 4 comments · Fixed by #1415
Closed

Re-enable configurable background transparency support #513

neiljp opened this issue Feb 24, 2020 · 4 comments · Fixed by #1415
Labels
area: colors/styles/themes help wanted This issue should be clear enough to work on

Comments

@neiljp
Copy link
Collaborator

neiljp commented Feb 24, 2020

In #378 we allowed the terminal to set the background color, to support transparent terminals.

However, due to the range of terminals and customization available, it is likely better if this is an option rather than assumed by default. For example, some users report that with the default scheme then the background color looks strange - this is likely the default background color from the terminal, and we likely want 'black' instead, unless the user specifically requests otherwise (for transparency)

We would want to enable setting this option in the config file and on the command line, as with other options.

UPDATE: Transparency support was lost in a recent theme data restructuring. This feature therefore needs adding back, through a configurable option (command-line, config) which likely should default to off.

@neiljp neiljp added the help wanted This issue should be clear enough to work on label Feb 24, 2020
@mregdos
Copy link
Collaborator

mregdos commented Mar 9, 2020

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Mar 19, 2020

Hello @mregdos, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

mregdos added a commit to mregdos/zulip-terminal that referenced this issue Mar 23, 2020
Default background is not transparent anymore.
Add --transparent flag and analogous option in config file which
may be used to set background's color based on terminal.

Fixes zulip#513.
@mregdos
Copy link
Collaborator

mregdos commented Mar 23, 2020

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Apr 6, 2020

Hello @mregdos, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@neiljp neiljp changed the title Enable background transparency only if specified Re-enable configurable background transparency support Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: colors/styles/themes help wanted This issue should be clear enough to work on
Projects
None yet
3 participants