Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support old format for narrow links (subject in addition to topic) #1422

Closed
neiljp opened this issue Aug 4, 2023 · 1 comment · Fixed by #1424
Closed

Support old format for narrow links (subject in addition to topic) #1422

neiljp opened this issue Aug 4, 2023 · 1 comment · Fixed by #1424
Assignees
@mounilKshah
Labels
area: message rendering area: UI General user interface update in progress version parity: <=2.1
Milestone
Next Release

Comments

@neiljp
Copy link
Collaborator

neiljp commented Aug 4, 2023

As documented in buttons.py (currently _parse_narrow_link), we support links formatted in the form:

... narrow/stream/[{stream-id}-]{stream-name}/topic/{encoded.20.topic.20name}[/near/{message_id}]

As I noted in #api documentation > Narrow URL formats this doesn't handle an old format where subject was used in place of topic, which makes the URL in the quoted message fail to be identified and link properly in ZT.

Servers running newer versions of Zulip will not generate links of this format, which limits the impact of this issue, but equally anyone who has upgraded an older server will potentially still have messages with links of this form.
@mounilKshah
Copy link
Collaborator

Given that nobody has claimed this issue so far, I'm working on it and hence, assigning it to myself.

@mounilKshah mounilKshah self-assigned this Aug 15, 2023
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Aug 15, 2023
@mounilKshah
buttons: Add support for old format for narrow links.
9824bb9 
This commit provides support to narrow links in quoted messages
containing 'subject' which may be present in messages pre-2.1.0
server version. Respective test cases have been added. Fixes zulip#1422.
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Aug 19, 2023
@mounilKshah
buttons: Add support for old format for narrow links.
6065476 
This commit provides support to narrow links in quoted messages
containing 'subject' which may be present in messages pre-2.1.0
server version. Respective test cases have been added. Fixes zulip#1422.
@mounilKshah mounilKshah mentioned this issue Aug 19, 2023
Merged
18 tasks
@neiljp neiljp added this to the Next Release milestone Aug 24, 2023
mounilKshah added a commit to mounilKshah/zulip-terminal that referenced this issue Aug 26, 2023
@mounilKshah
buttons: Add support for old format for narrow links.
cdbd2e9 
This commit provides support to narrow links in quoted messages
containing 'subject' which may be present in messages pre-2.1.0
server version. Respective test cases have been added. Fixes zulip#1422.
neiljp pushed a commit to mounilKshah/zulip-terminal that referenced this issue Aug 29, 2023
@mounilKshah @neiljp
buttons: Add support for old format for narrow links.
9d4e7aa 
This commit provides support for narrow links in message content
containing 'subject' instead of 'topic', which may be present in
messages before server version 2.1.0.

Test cases added.

Fixes zulip#1422.
neiljp pushed a commit that referenced this issue Sep 3, 2023
@mounilKshah @neiljp
buttons: Add support for old format for narrow links.
2e9ef5b 
This commit provides support for narrow links in message content
containing 'subject' instead of 'topic', which may be present in
messages before server version 2.1.0.

Test cases added.

Fixes #1422.
Subhasish-Behera pushed a commit to Subhasish-Behera/zulip-terminal that referenced this issue Oct 27, 2023
@mounilKshah @Subhasish-Behera
buttons: Add support for old format for narrow links.
bb99efd 
This commit provides support for narrow links in message content
containing 'subject' instead of 'topic', which may be present in
messages before server version 2.1.0.

Test cases added.

Fixes zulip#1422.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mounilKshah mounilKshah

Labels
area: message rendering area: UI General user interface update in progress version parity: <=2.1
Projects
None yet
Milestone
Next Release
Development

Successfully merging a pull request may close this issue.

Add support for old format for narrow links mounilKshah/zulip-terminal
3 participants
@neiljp @zulipbot @mounilKshah