Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #5553 : Warning message before unsubscribing from a stream #5579

Closed
wants to merge 1 commit into from

Conversation

arijitghosal03
Copy link

No description provided.

@chrisbobbe
Copy link
Contributor

Hi! Could you please say more about the reason for this proposed change? 🙂

@arijitghosal03
Copy link
Author

arijitghosal03 commented Dec 2, 2022

Hi @chrisbobbe , I was working on the issue #5553 and found that (StreamSettingsScreen.js) no alert message before unsubscribing from a Stream. My idea was to add an alert component where is the user chooses the ("OK") button, the execution gets directed to Unsubscribe function where his subscription gets cancelled. The above mentioned changes has been done in the JavaScript file

@arijitghosal03 arijitghosal03 changed the title Update ci.yml Warning message before unsubscribing from a stream Dec 2, 2022
@arijitghosal03 arijitghosal03 changed the title Warning message before unsubscribing from a stream Fixed issue #5568 : Warning message before unsubscribing from a stream Dec 2, 2022
@arijitghosal03 arijitghosal03 changed the title Fixed issue #5568 : Warning message before unsubscribing from a stream Fixed issue #5578 : Warning message before unsubscribing from a stream Dec 2, 2022
@arijitghosal03 arijitghosal03 changed the title Fixed issue #5578 : Warning message before unsubscribing from a stream Fixed issue #5553 : Warning message before unsubscribing from a stream Dec 2, 2022
@gnprice
Copy link
Member

gnprice commented Dec 2, 2022

Hi @chrisbobbe , I was working on the issue #5553 and found that (StreamSettingsScreen.js) no alert message before unsubscribing from a Stream. My idea was to add an alert component where is the user chooses the ("OK") button, the execution gets directed to Unsubscribe function where his subscription gets cancelled. The above mentioned changes has been done in the JavaScript file

It sounds like you're perhaps describing your other PR #5578.

This PR has just one commit, aec646d. It makes one change:

--- .github/workflows/ci.yml
+++ .github/workflows/ci.yml
@@ -6,7 +6,7 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
 
     - name: Set up JDK
       uses: actions/setup-java@v1

Can you say more about what led you to that change? Perhaps it'd be good to update that dependency, but I haven't noticed anything about it to draw my attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants