flow [nfc]: Convert $PropertyType and $ElementType to indexed-access syntax #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such a nicer syntax! This is available to us now that we've upgraded Prettier: zulip#5393 (comment) and Flow before that: zulip#5398 (comment) We'll similarly convert $ElementType in the next commit. Done mostly with a crude search-and-replace: $ perl -i -0pe ' s/\$PropertyType<(.*?),\s*(.*?)>/${1}[$2]/gs ' src/**/*.js types/**.js.flow flow-typed/**/*.js That doesn't behave right in the presence of nesting; but there was only one case of that, so just fixed it up by hand.
For the same reasons as for $PropertyType in the preceding commit.
Done mostly with another crude search-and-replace:
$ perl -i -0pe '
s/\$ElementType<(.*?),\s*(.*?)>/($1)[$2]/gs
' src/**/*.js
Then manually fixed the only place that got wrong, plus the spot in
types/react-intl.js.flow it would have gotten wrong.
Leave in place a number of uses of $ElementType in TsFlower output.
The right way to update those will be for TsFlower to switch to
emitting the new syntax.
|
Yay, thanks! LGTM; merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such a nicer syntax! This is available to us now that we've
upgraded Prettier:
#5393 (comment)
and Flow before that:
#5398 (comment)
Leave in place a number of uses of $ElementType in TsFlower output.
The right way to update those will be for TsFlower to switch to
emitting the new syntax.