Show "(guest)" by guest users' names, when setting enabled #5804

chrisbobbe · 2023-12-20T19:06:34Z

This is to implement the "guest indicator" feature on mobile. Discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Guest.20user.20indicator/near/1707770

But if it's not in user data, just fall back to the user's name on the message. Soon we'll use the user data to show a "(guest)" marker if it applies; this is zulip#5804. The header doesn't actually live-update when a recipient user's name changes (zulip#5208), because we don't yet use InboundEventEditSequence. But I've added logic in the code that builds that inbound event, so that the live-updating will happen if we ever do start using it. Like we did for the followed-topic marker on stream recipient headers, in 4ef0a0a.

…able But if it's not in user data, just fall back to sender_full_name on the message, since that seems better than showing "(unknown user)". Like in the previous commit, the main motivation for this is that our new helper functions that will power the upcoming "Firstname Lastname (guest)" feature, zulip#5804, need a User object.

But if it's not in user data, just fall back to the user's name on the message. Soon we'll use the user data to show a "(guest)" marker if it applies; this is zulip#5804. But as a bonus, this means that as long as we have a User object (which we usually will), we'll live-update the sender's name, here, if it changes.

And do some nice cleanups that this enables. See kMinAllowedServerVersion, which is 4.0. Now, we can implement the "guest indicator" feature (zulip#5804) without having to write unused fallback code for a missing `.role`.

Making sure that it chooses '(unknown user)' or 'Muted user', as appropriate. We're about to add another of that kind of thing -- 'Firstname Lastname (guest)' -- for zulip#5804.

Soon we'll have a version of the "full name or muted user text" that's LocalizableReactText, not LocalizableText, because we want to offer an italicized "(guest)" marker, for zulip#5804. Prepare for that by using ZulipTextIntl for the names, since it can handle LocalizableReactText, and our GetText function `_` cannot.

…g on Fixes: zulip#5804

Making sure that it chooses '(unknown user)' or 'Muted user', as appropriate. We're about to add another of that kind of thing -- 'Firstname Lastname (guest)' -- for zulip#5804.

Soon we'll have a version of the "full name or muted user text" that's LocalizableReactText, not LocalizableText, because we want to offer an italicized "(guest)" marker, for zulip#5804. Prepare for that by using ZulipTextIntl for the names, since it can handle LocalizableReactText, and our GetText function `_` cannot.

…g on Fixes: zulip#5804

But if it's not in user data, just fall back to the user's name on the message. Soon we'll use the user data to show a "(guest)" marker if it applies; this is zulip#5804. The header doesn't actually live-update when a recipient user's name changes (zulip#5208), because we don't yet use InboundEventEditSequence. But I've added logic in the code that builds that inbound event, so that the live-updating will happen if we ever do start using it. Like we did for the followed-topic marker on stream recipient headers, in 4ef0a0a.

…able But if it's not in user data, just fall back to sender_full_name on the message, since that seems better than showing "(unknown user)". Like in the previous commit, the main motivation for this is that our new helper functions that will power the upcoming "Firstname Lastname (guest)" feature, zulip#5804, need a User object. In the tests for the "content" WebView inbound event, tweak the example message so that its sender is the self-user. That's so the tested code can access the sender's User object, since the self-user is already included in the test's background data.

But if it's not in user data, just fall back to the user's name on the message. Soon we'll use the user data to show a "(guest)" marker if it applies; this is zulip#5804. But as a bonus, this means that as long as we have a User object (which we usually will), we'll live-update the sender's name, here, if it changes.

And do some nice cleanups that this enables. See kMinAllowedServerVersion, which is 4.0. Now, we can implement the "guest indicator" feature (zulip#5804) without having to write unused fallback code for a missing `.role`.

Making sure that it chooses '(unknown user)' or 'Muted user', as appropriate. We're about to add another of that kind of thing -- 'Firstname Lastname (guest)' -- for zulip#5804.

Soon we'll have a version of the "full name or muted user text" that's LocalizableReactText, not LocalizableText, because we want to offer an italicized "(guest)" marker, for zulip#5804. Prepare for that by using ZulipTextIntl for the names, since it can handle LocalizableReactText, and our GetText function `_` cannot.

…g on Fixes: zulip#5804

But if it's not in user data, just fall back to the user's name on the message. Soon we'll use the user data to show a "(guest)" marker if it applies; this is zulip#5804. The header doesn't actually live-update when a recipient user's name changes (zulip#5208), because we don't yet use InboundEventEditSequence. But I've added logic in the code that builds that inbound event, so that the live-updating will happen if we ever do start using it. Like we did for the followed-topic marker on stream recipient headers, in 4ef0a0a.

…able But if it's not in user data, just fall back to sender_full_name on the message, since that seems better than showing "(unknown user)". Like in the previous commit, the main motivation for this is that our new helper functions that will power the upcoming "Firstname Lastname (guest)" feature, zulip#5804, need a User object. In the tests for the "content" WebView inbound event, tweak the example message so that its sender is the self-user. That's so the tested code can access the sender's User object, since the self-user is already included in the test's background data.

But if it's not in user data, just fall back to the user's name on the message. Soon we'll use the user data to show a "(guest)" marker if it applies; this is zulip#5804. But as a bonus, this means that as long as we have a User object (which we usually will), we'll live-update the sender's name, here, if it changes.

And do some nice cleanups that this enables. See kMinAllowedServerVersion, which is 4.0. Now, we can implement the "guest indicator" feature (zulip#5804) without having to write unused fallback code for a missing `.role`.

Making sure that it chooses '(unknown user)' or 'Muted user', as appropriate. We're about to add another of that kind of thing -- 'Firstname Lastname (guest)' -- for zulip#5804.

Soon we'll have a version of the "full name or muted user text" that's LocalizableReactText, not LocalizableText, because we want to offer an italicized "(guest)" marker, for zulip#5804. Prepare for that by using ZulipTextIntl for the names, since it can handle LocalizableReactText, and our GetText function `_` cannot.

…g on Fixes: zulip#5804

And do some nice cleanups that this enables. See kMinAllowedServerVersion, which is 4.0. Now, we can implement the "guest indicator" feature (zulip#5804) without having to write unused fallback code for a missing `.role`.

Making sure that it chooses '(unknown user)' or 'Muted user', as appropriate. We're about to add another of that kind of thing -- 'Firstname Lastname (guest)' -- for zulip#5804.

Soon we'll have a version of the "full name or muted user text" that's LocalizableReactText, not LocalizableText, because we want to offer an italicized "(guest)" marker, for zulip#5804. Prepare for that by using ZulipTextIntl for the names, since it can handle LocalizableReactText, and our GetText function `_` cannot.

chrisbobbe added the P1 high-priority label Dec 20, 2023

chrisbobbe mentioned this issue Dec 20, 2023

api types: Update InitialDataRealm and RealmDataForUpdate to FL 237 #5806

Merged

chrisbobbe self-assigned this Dec 20, 2023

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Dec 22, 2023

ui: Show "(guest)" indicator on guest users' names, when realm settin…

f77b836

…g on Fixes: zulip#5804

chrisbobbe mentioned this issue Dec 22, 2023

Show "(guest)" by guest users' names, when setting enabled #5809

Merged

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Dec 22, 2023

ui: Show "(guest)" indicator on guest users' names, when realm settin…

01c538c

…g on Fixes: zulip#5804

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jan 4, 2024

ui: Show "(guest)" indicator on guest users' names, when realm settin…

c510fdf

…g on Fixes: zulip#5804

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jan 4, 2024

ui: Show "(guest)" indicator on guest users' names, when realm settin…

1c06438

…g on Fixes: zulip#5804

chrisbobbe closed this as completed in 9171d7d Jan 5, 2024

neiljp mentioned this issue Jan 6, 2024

Add guest user suffix, depending on organization setting zulip/zulip-terminal#1444

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show "(guest)" by guest users' names, when setting enabled #5804

Show "(guest)" by guest users' names, when setting enabled #5804

chrisbobbe commented Dec 20, 2023

Show "(guest)" by guest users' names, when setting enabled #5804

Show "(guest)" by guest users' names, when setting enabled #5804

Comments

chrisbobbe commented Dec 20, 2023