-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to test mobile push notifications #5796
Comments
Also, is there a reason not to also add a test-notification button on the notification troubleshooting screen? |
For iOS, the heading and text are defined in the push bouncer: https://github.com/zulip/zulip/blob/78440033dc7b7f0dbf323215def7d9c784f04ad4/zerver/lib/push_notifications.py#L1283-L1290 "title": _("Test notification"),
"body": _("This is a test notification from {realm_uri}.").format(realm_uri=realm_uri), so we would need to change it there. I slightly prefer the more neutral "this is a test notification" text. Saying that "notifications are working" doesn't seem helpful if you're trying the button because your notifications have been severely delayed, whether or not the test notification itself arrives on time. You could also have an issue with how notifications are presented (the sound/banner/vibration/etc.), or just want to remind yourself how they're presented, and to me a neutral-sounding message seems appropriate for those cases too. |
Are you thinking both that screen and the general notifications screen? That seems reasonable to me... |
Could you start a thread on CZO to discuss the text? I was thinking of a different use case, which is an IT person who just set up a Zulip server; I guess we should consider both. |
I'm fine with the proposed placement. |
Thanks for framing up all the questions! |
|
Tested on the office Android device, and on my iPhone. For the iOS testing, I set up a dev server to talk directly to Apple's APNs "sandbox" server, with our documented instructions: https://github.com/zulip/zulip-mobile/blob/main/docs/howto/push-notifications.md#testing-client-side-changes-on-ios (I already had the relevant certificate, so I didn't need to go through the steps with a certificate signing request.) Fixes: zulip#5796
The server now supports test push notifications. We should make it convenient to trigger such a notification from the mobile app.
The text was updated successfully, but these errors were encountered: