Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render @topic wildcard mentions correctly when displayed in a message feed. #5746

Closed
prakhar1144 opened this issue Jul 13, 2023 · 1 comment · Fixed by #5779
Closed

Render @topic wildcard mentions correctly when displayed in a message feed. #5746

prakhar1144 opened this issue Jul 13, 2023 · 1 comment · Fixed by #5779
Assignees
@chrisbobbe
Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@prakhar1144
Copy link
Member

CZO discussion

For stream wildcard mentions (all, everyone, stream), the rendered content is:

<span class="user-mention" data-user-id="*">@{stream_wildcard}</span>

As a part of the @topic wildcard mentions project ( #22829 ) , we have introduced @topic; the rendered content is:

<span class="topic-mention">@{topic_wildcard}</span>

Since we are not using user-mention class (and data-user-id="*" attribute), the @topic mention is not rendered correctly.

#26195 (comment)
@chrisbobbe chrisbobbe added server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. labels Oct 11, 2023
@chrisbobbe
Copy link
Contributor

Just added metadata to make this appear in the Zulip Server 8.0 project board; FYI @alya and @gnprice.

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Oct 11, 2023
@chrisbobbe
content: Render @topic mentions correctly
282fe61 
Fixes: zulip#5746
@chrisbobbe chrisbobbe mentioned this issue Oct 11, 2023
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Oct 18, 2023
@chrisbobbe
content: Render @topic mentions correctly
9a79879 
Fixes: zulip#5746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
No open projects
Zulip Server 8.0 priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle @topic mentions chrisbobbe/zulip-mobile
2 participants
@chrisbobbe @prakhar1144