Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take babel-eslint's move to @babel/eslint-parser. #4254

Closed
chrisbobbe opened this issue Sep 10, 2020 · 0 comments
Closed

Take babel-eslint's move to @babel/eslint-parser. #4254

chrisbobbe opened this issue Sep 10, 2020 · 0 comments
Labels
a-tools blocked on other work To come back to after another related PR, or some other task. dependencies Pull requests that update a dependency file

Comments

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Sep 10, 2020 •
edited
Loading

In July, Babel made an announcement:

With the next iteration of babel-eslint, we have decided to publish the package under a new name: @babel/eslint-parser.

We may also like to consider @babel/eslint-plugin, the new home of eslint-plugin-babel. For one data point, reportedly, this plugin would help us suppress false positives from ESLint's no-unused-expressions rule centrally and precisely, where such false positives occur when using method calls with optional chaining.

Blocked by the ESLint 7 upgrade (#4253) because @babel/eslint-parser does not have a version on NPM that supports ESLint 6. The same is true of @babel/eslint-plugin.
@chrisbobbe chrisbobbe added a-tools blocked on other work To come back to after another related PR, or some other task. dependencies Pull requests that update a dependency file labels Sep 10, 2020
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Sep 18, 2020
@chrisbobbe
ComposeBox [nfc]: Use optional chaining instead of if block.
f3ab7a0 
Prompted by discussion on zulip#4101 [1].

Flow started supporting method calls in optional chains in
v0.112.0 [2], but ESLint isn't yet on board [3]; it gives a false
positive for `no-unused-expressions`.

A comment on the ESLint issue [4] suggests we could be more
systematic by using an ESLint plugin from Babel, instead of one-off
suppressions of `no-unused-expressions` like this one. That plugin
moved from (on NPM) `babel-eslint-plugin` to `@babel/eslint-plugin`.
We can't use the new one until we're on ESLint 7 (see zulip#4254), but we
could probably use the old one.

[1] zulip#4101 (comment)
[2] facebook/flow#4303
[3] eslint/eslint#11045
[4] eslint/eslint#11045 (comment)
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Sep 19, 2020
@chrisbobbe
ComposeBox [nfc]: Use optional chaining instead of if block.
a169908 
Prompted by discussion on zulip#4101 [1].

Flow started supporting method calls in optional chains in
v0.112.0 [2], but ESLint isn't yet on board [3]; it gives a false
positive for `no-unused-expressions`.

A comment on the ESLint issue [4] suggests we could be more
systematic by using an ESLint plugin from Babel, instead of one-off
suppressions of `no-unused-expressions` like this one. That plugin
moved from (on NPM) `babel-eslint-plugin` to `@babel/eslint-plugin`.
We can't use the new one until we're on ESLint 7 (see zulip#4254), but we
could probably use the old one.

[1] zulip#4101 (comment)
[2] facebook/flow#4303
[3] eslint/eslint#11045
[4] eslint/eslint#11045 (comment)
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Sep 21, 2020
@chrisbobbe
ComposeBox [nfc]: Use optional chaining instead of if block.
98c1549 
Prompted by discussion on zulip#4101 [1].

Flow started supporting method calls in optional chains in
v0.112.0 [2], but ESLint isn't yet on board [3]; it gives a false
positive for `no-unused-expressions`.

A comment on the ESLint issue [4] suggests we could be more
systematic by using an ESLint plugin from Babel, instead of one-off
suppressions of `no-unused-expressions` like this one. That plugin
moved from (on NPM) `babel-eslint-plugin` to `@babel/eslint-plugin`.
We can't use the new one until we're on ESLint 7 (see zulip#4254), but we
could probably use the old one.

[1] zulip#4101 (comment)
[2] facebook/flow#4303
[3] eslint/eslint#11045
[4] eslint/eslint#11045 (comment)
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Sep 21, 2020
@chrisbobbe
ComposeBox [nfc]: Use optional chaining instead of if block.
682a6b7 
Prompted by discussion on zulip#4101 [1].

Flow started supporting method calls in optional chains in
v0.112.0 [2], but ESLint isn't yet on board [3]; it gives a false
positive for `no-unused-expressions`.

A comment on the ESLint issue [4] suggests we could be more
systematic by using an ESLint plugin from Babel, instead of one-off
suppressions of `no-unused-expressions` like this one. That plugin
moved from (on NPM) `babel-eslint-plugin` to `@babel/eslint-plugin`.
We can't use the new one until we're on ESLint 7 (see zulip#4254), but we
could probably use the old one.

[1] zulip#4101 (comment)
[2] facebook/flow#4303
[3] eslint/eslint#11045
[4] eslint/eslint#11045 (comment)
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 26, 2022
@chrisbobbe
wip js: Update prettier-eslint, etc., to latest!!
3db2f86 
TODO: find out what we actually want :) and finish commit message

Following the eagerly awaited resolution of
  prettier/prettier-eslint-cli#304

- add some @babel/ deps for peer-dep requirements

- resolutions line to get
  prettier/prettier-eslint#749

Fixes: zulip#4254
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jun 2, 2022
@chrisbobbe
eslint: Take babel-eslint's move to @babel/eslint-parser
9835f26 
Fixes: zulip#4254
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jun 3, 2022
@chrisbobbe
eslint: Take babel-eslint's move to @babel/eslint-parser
aa0806e 
Fixes: zulip#4254
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jun 8, 2022
@chrisbobbe
eslint: Take babel-eslint's move to @babel/eslint-parser
4bf97d0 
Fixes: zulip#4254
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jun 9, 2022
@chrisbobbe
eslint: Take babel-eslint's move to @babel/eslint-parser
01d39a8 
Fixes: zulip#4254
@gnprice gnprice closed this as completed in e183358 Jun 9, 2022
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jul 20, 2022
@chrisbobbe
flow-todo: Switch parser to @babel/eslint-parser, from babel-eslint
de045e5 
Oops, looks like we should have done this in e183358, for zulip#4254.

I'm not sure how much we actually want to keep the `test:flow-todo`
command, but might as well bring it up to date.

We're about to change it again, to hermes-eslint, along with our
other ESLint configs.
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jul 20, 2022
@chrisbobbe
flow-todo: Switch parser to @babel/eslint-parser, from babel-eslint
acf00b1 
Oops, looks like we should have done this in e183358, for zulip#4254.

I'm not sure how much we actually want to keep the `test:flow-todo`
command, but might as well bring it up to date in this way.

We're about to change it again, to hermes-eslint, along with our
other ESLint configs.
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jul 26, 2022
@chrisbobbe
flow-todo: Switch parser to @babel/eslint-parser, from babel-eslint
a418d38 
Oops, looks like we should have done this in e183358, for zulip#4254.

I'm not sure how much we actually want to keep the `test:flow-todo`
command, but might as well bring it up to date in this way.

We're about to change it again, to hermes-eslint, along with our
other ESLint configs.
gnprice pushed a commit that referenced this issue Aug 3, 2022
@chrisbobbe @gnprice
flow-todo: Switch parser to @babel/eslint-parser, from babel-eslint
16d1182 
Oops, looks like we should have done this in e183358, for #4254.

I'm not sure how much we actually want to keep the `test:flow-todo`
command, but might as well bring it up to date in this way.

We're about to change it again, to hermes-eslint, along with our
other ESLint configs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-tools blocked on other work To come back to after another related PR, or some other task. dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisbobbe