js [nfc]: Remove some useless param defaulting

I caught these while experimenting with a new(ish) eslint rule: https://eslint.org/docs/rules/default-param-last
zulip · May 26, 2022 · ace1ab2 · ace1ab2
1 parent e6824f3
commit ace1ab2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/users/userHelpers.js b/src/users/userHelpers.js
@@ -79,7 +79,7 @@ export const filterUserList = (
 
 export const filterUserStartWith = (
   users: $ReadOnlyArray<AutocompleteOption>,
-  filter: string = '',
+  filter: string,
   ownUserId: UserId,
 ): $ReadOnlyArray<AutocompleteOption> => {
   const loweredFilter = filter.toLowerCase();
@@ -92,7 +92,7 @@ export const filterUserStartWith = (
 
 export const filterUserThatContains = (
   users: $ReadOnlyArray<AutocompleteOption>,
-  filter: string = '',
+  filter: string,
   ownUserId: UserId,
 ): $ReadOnlyArray<AutocompleteOption> => {
   const loweredFilter = filter.toLowerCase();
@@ -105,7 +105,7 @@ export const filterUserThatContains = (
 
 export const filterUserMatchesEmail = (
   users: $ReadOnlyArray<AutocompleteOption>,
-  filter: string = '',
+  filter: string,
   ownUserId: UserId,
 ): $ReadOnlyArray<AutocompleteOption> =>
   users.filter(
@@ -128,7 +128,7 @@ export const getUsersAndWildcards = (
 
 export const getAutocompleteSuggestion = (
   users: $ReadOnlyArray<AutocompleteOption>,
-  filter: string = '',
+  filter: string,
   ownUserId: UserId,
   mutedUsers: MutedUsersState,
 ): $ReadOnlyArray<AutocompleteOption> => {

diff --git a/src/utils/internalLinks.js b/src/utils/internalLinks.js
@@ -8,7 +8,7 @@ import { pmKeyRecipientsFromIds } from './recipient';
 
 // TODO: Work out what this does, write a jsdoc for its interface, and
 // reimplement using URL object (not just for the realm)
-const getPathsFromUrl = (url: string = '', realm: URL) => {
+const getPathsFromUrl = (url: string, realm: URL) => {
   const paths = url
     .split(realm.toString())
     .pop()

diff --git a/src/utils/url.js b/src/utils/url.js
@@ -93,7 +93,7 @@ export const tryParseUrl = (url: string, base?: string | URL): URL | void => {
 
 // TODO: Work out what this does, write a jsdoc for its interface, and
 // reimplement using URL object (not just for the realm)
-export const isUrlOnRealm = (url: string = '', realm: URL): boolean =>
+export const isUrlOnRealm = (url: string, realm: URL): boolean =>
   url.startsWith('/') || url.startsWith(realm.toString()) || !/^(http|www.)/i.test(url);
 
 const getResourceWithAuth = (uri: string, auth: Auth) => ({