add unicode error catching #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So i found this when i hit some non unicode files. examples of some errors caught with this this is a rough fix but at least allows tests to complete. without this catch the script would crash ``` unable to process file (path removed) due to unicode decode error 'utf-8' codec can't decode byte 0xa7 in position 195: invalid start byte unable to process file (path removed) due to unicode decode error 'utf-8' codec can't decode byte 0xa1 in position 33: invalid start byte ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So i found this when i hit some non unicode files.
examples of some errors caught with this
this is a rough fix but at least allows tests to complete. without this catch the script would crash
The script probably shouldnt just assume a file is going to be utf8 encoded