Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with psc-0.9.1 #12

Merged
merged 3 commits into from
Jul 6, 2016
Merged

Make it work with psc-0.9.1 #12

merged 3 commits into from
Jul 6, 2016

Conversation

eskimor
Copy link
Contributor

@eskimor eskimor commented Jun 20, 2016

It depends on some PRs to other packages which are not yet merged.

It depends on some PRs to other packages which are not yet merged.
@eskimor
Copy link
Contributor Author

eskimor commented Jun 20, 2016

To be precise:
purescript-deprecated/purescript-dom#53 - already merged
zudov/purescript-var#2

@eskimor
Copy link
Contributor Author

eskimor commented Jun 26, 2016

@zudov only the PR for zudov/purescript-var is missing. Then this PR should be fine.

@adarqui
Copy link

adarqui commented Jul 1, 2016

I need this (and purescript-var) too. Thanks @eskimor.

@eskimor
Copy link
Contributor Author

eskimor commented Jul 1, 2016

@adarqui You are welcome ;-)

@eskimor
Copy link
Contributor Author

eskimor commented Jul 6, 2016

ping @zudov can this be merged?

@zudov
Copy link
Owner

zudov commented Jul 6, 2016

Looks good and builds fine. CI still fails due to not bumped dependencies in example/bower.json, but I can fix that once it's merged.

Thanks a lot for help with that, and sorry that I don't keep track of such things.

@zudov zudov merged commit 749489a into zudov:master Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants