-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oh-my-zsh is not the only ZSH framework that uses plugin.zsh files #48
Comments
Couldn't we update those other frameworks to reinstate whatever subset of the removed configuration they use on their end? Because those |
❗ Ping @unixorn. Is this still an issue? Have those frameworks reconfigured this plugin since? Thanks. |
@sunaku You can easily fix this issue by having a commit like this one: Tarrasch@f20ed56, I already did it in sindresorhus/pure#75 and it was appreciated there. :) |
@sunaku - Sorry, I managed to miss your previous comment. The other frameworks don't have code specific to this plugin, it is that their generic plugin handling code assumes they'll find |
Per @desyncr's answer in #59 (comment), this extra |
@sunaku, All this said. I have strong opinions about this and in fact I have even made my own fairly popular plugin manager. :) |
I'm against providing a conventional Instead, I want users to look through the README and then define the keybindings and configure the documented variables to suit their own personal needs. 📖 It's a one-time thing: Just set it and forget it! 🎐 |
I'm not sure what you mean with different out-of-the-box experiences. See my post above. That you both use a plugin manager and read the README/do configuring is nothing unique to this plugin. |
Restoring However, I now understand that you're asking for something else: you want to provide a |
Well, at least I feel confident that you understand what I mean now. I personally would stick to follow conventions to comply to as many plugin managers as possible. But I suppose you don't want the extra clutter of a symlink and stuff. Thanks for talking this through! :) |
Many other ZSH frameworks like zgen and Antigen use .plugin.zsh files for compatibility with oh-my-zsh.
2f8a5f8 removes functionality for some non-oh-my-zsh-frameworks.
The text was updated successfully, but these errors were encountered: