Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_yarn: fix parsing of yarn run on scripts containing } #668

Merged
merged 1 commit into from
Jan 17, 2020
Merged

_yarn: fix parsing of yarn run on scripts containing } #668

merged 1 commit into from
Jan 17, 2020

Conversation

mcornella
Copy link
Contributor

@mcornella mcornella commented Nov 3, 2019

When a package.json script command uses the closing curly brace, the current yarn run parsing fails to capture the whole hints property value, leading to it not parsing correctly the rest of the scripts commands. See #667.

This solution uses the fact that the hints property value always ends with a double quote and a closing curly brace to match the whole property value, disregarding whether a closing curly brace is used in a script command. See #667 (comment).

Fixes #667

  • This compdef is not already available in zsh.
  • This compdef is not already available in their original project.
  • I am the original author, or I have authorization to submit this work.
  • This is a finished work.
  • It has a header containing authors, status and origin of the script.
  • It has a license header or I accept that it will be licensed under the terms of the Zsh license.

@MaximDevoir MaximDevoir merged commit e32536a into zsh-users:master Jan 17, 2020
@mcornella mcornella deleted the fix-yarn-run-parse branch January 17, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn | } character in script command blocks suggestions
2 participants