Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #34 delete querystring in labels #35

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Conversation

cupen
Copy link
Contributor

@cupen cupen commented May 31, 2019

fix #34

@cupen
Copy link
Contributor Author

cupen commented Jun 18, 2019

@zsais Hello?

@cupen
Copy link
Contributor Author

cupen commented Jul 22, 2019

@zsai Hello, it‘s a very big problem, it will cause too many memory usage, both with your metrics program and prometheus tsdb.
heres is my prometheus logs.

level=info ts=2019-07-21T05:10:05.029Z caller=main.go:668 msg="TSDB started"
level=info ts=2019-07-21T05:10:05.040Z caller=main.go:738 msg="Loading configuration file" filename=/etc/prometheus/prometheus.yml
level=info ts=2019-07-21T05:10:05.060Z caller=main.go:766 msg="Completed loading of configuration file" filename=/etc/prometheus/prometheus.yml
level=info ts=2019-07-21T05:10:05.060Z caller=main.go:621 msg="Server is ready to receive web requests."
level=info ts=2019-07-21T05:10:22.567Z caller=compact.go:495 component=tsdb msg="write block" mint=1563674400000 maxt=1563681600000 ulid=01DG9EZZ2R2GNAB73MF3TF85ED duration=9.230158995s
level=info ts=2019-07-21T05:10:24.785Z caller=head.go:586 component=tsdb msg="head GC completed" duration=742.465478ms
level=info ts=2019-07-21T05:10:40.581Z caller=head.go:656 component=tsdb msg="WAL checkpoint complete" first=42 last=45 duration=15.795350131s
level=warn ts=2019-07-21T06:33:54.405Z caller=scrape.go:952 component="scrape manager" scrape_pool=game target=http://172.17.125.122:3301/metrics msg="appending scrape report failed" err="out of bounds"
level=info ts=2019-07-21T07:30:34.769Z caller=compact.go:495 component=tsdb msg="write block" mint=1563681600000 maxt=1563688800000 ulid=01DG9P39F74KY4H1E8CB711G5G duration=16m12.466554245s
level=info ts=2019-07-21T07:30:40.598Z caller=head.go:586 component=tsdb msg="head GC completed" duration=975.988923ms
level=info ts=2019-07-21T07:30:45.915Z caller=head.go:656 component=tsdb msg="WAL checkpoint complete" first=46 last=48 duration=5.284232112s
level=info ts=2019-07-21T09:13:20.501Z caller=compact.go:495 component=tsdb msg="write block" mint=1563688800000 maxt=1563696000000 ulid=01DG9WCY2FMF2K4RMHGT9AGRQP duration=8m50.730077783s
level=info ts=2019-07-21T09:14:33.813Z caller=head.go:586 component=tsdb msg="head GC completed" duration=1.319307159s
level=info ts=2019-07-21T09:14:38.789Z caller=head.go:656 component=tsdb msg="WAL checkpoint complete" first=49 last=50 duration=4.948203164s
level=info ts=2019-07-21T09:19:33.043Z caller=compact.go:440 component=tsdb msg="compact blocks" count=3 mint=1563667200000 maxt=1563688800000 ulid=01DG9WZJRDDA0QTM2CXYQDAK2S sources="[01DG97HHZD07CFXGXY4EZF3J94 01DG9EZZ2R2GNAB73MF3TF85ED 01DG9P39F74KY4H1E8CB711G5G]" duration=4m52.264798276s
level=info ts=2019-07-21T09:20:39.310Z caller=compact.go:440 component=tsdb msg="compact blocks" count=3 mint=1563624000000 maxt=1563688800000 ulid=01DG9X8QAXDC00TGWDAV7YQRVJ sources="[01DG8JYVNX93167ZS0GKGCRQKV 01DG97J3895BNE3PFKC3X8CKZW 01DG9WZJRDDA0QTM2CXYQDAK2S]" duration=58.934321964s
level=warn ts=2019-07-21T12:07:34.856Z caller=scrape.go:952 component="scrape manager" scrape_pool=game target=http://172.17.125.122:3301/metrics msg="appending scrape report failed" err="out of bounds"
level=info ts=2019-07-21T12:50:54.838Z caller=compact.go:495 component=tsdb msg="write block" mint=1563696000000 maxt=1563703200000 ulid=01DGA5ZR14FWX37HQP48A3S5TY duration=58m51.475949916s

It's horrible.

@cupen
Copy link
Contributor Author

cupen commented Jul 22, 2019

I'll use my local fork before it be merged
go.mod

replace github.com/zsais/go-gin-prometheus => github.com/cupen/go-gin-prometheus patch-1

@zsais zsais merged commit c7374e9 into zsais:master Jul 23, 2019
@cupen cupen deleted the patch-1 branch July 24, 2019 05:26
prymitive added a commit to prymitive/karma that referenced this pull request Aug 8, 2019
prymitive added a commit to prymitive/karma that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete querystring in metrics labels.
3 participants