Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planck Ez disable leds #74

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Planck Ez disable leds #74

merged 1 commit into from
Jun 7, 2019

Conversation

fdidron
Copy link
Collaborator

@fdidron fdidron commented Jun 7, 2019

Description

The Planck EZ comes in two versions, one with leds (Glow), one without (Standard). This patch allows to disable leds in userspace for the Standard version.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fdidron fdidron added the enhancement New feature or request label Jun 7, 2019
@fdidron fdidron requested a review from drashna June 7, 2019 05:31
@fdidron fdidron self-assigned this Jun 7, 2019
@fdidron fdidron requested a review from ezuk June 7, 2019 11:15
@ezuk ezuk merged commit a31212a into master Jun 7, 2019
@ezuk ezuk deleted the planckez-disable-leds branch June 7, 2019 14:41
@drashna
Copy link
Collaborator

drashna commented Jun 7, 2019

I'll see about backporting this change to QMK, as well.

@fdidron
Copy link
Collaborator Author

fdidron commented Jun 8, 2019

@drashna Thanks, I kinda fast tracked this one since it is a requirement from our manufacturer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants