Skip to content

Commit

Permalink
fix: only try and refresh data shapes for dynamic actions; fixes synd…
Browse files Browse the repository at this point in the history
  • Loading branch information
gashcrumb authored and zregvart committed Mar 31, 2019
1 parent 54fe129 commit 2c2bb4b
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions app/ui/src/app/integration/edit-page/current-flow.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export class CurrentFlowService {
}

isValid(): boolean {
// TODO more validations on the integration
// TODO: more validations on the integration
return this.integration.name && this.integration.name.length > 0;
}

Expand Down Expand Up @@ -655,11 +655,13 @@ export class CurrentFlowService {
outstanding = outstanding + 1;
switch (step.stepKind) {
case ENDPOINT:
// Update metadata but the connection needs to be configured
// Update metadata but the connection needs to be configured and the action needs to be tagged as dynamic
if (
typeof step.connection !== 'undefined' &&
typeof step.action !== 'undefined' &&
typeof step.configuredProperties !== 'undefined'
typeof step.configuredProperties !== 'undefined' &&
typeof step.action.tags.find(tag => tag === 'dynamic') !==
'undefined'
) {
this.fetchStepMetadata(step, position, decrementCount);
} else {
Expand Down

0 comments on commit 2c2bb4b

Please sign in to comment.