Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role=img to rendered canvas & svg #321

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Add role=img to rendered canvas & svg #321

merged 1 commit into from
Oct 29, 2023

Conversation

zpao
Copy link
Owner

@zpao zpao commented Oct 28, 2023

This isn't strictly necessary for <canvas> (AFAICT) but should be done for inline SVG.

As surfaced in #319

This isn't strictly necessary for `<canvas>` (AFAICT) but should be done
for inline SVG.
zpao added a commit that referenced this pull request Oct 28, 2023
Missed adding this after #283. With #321 we have a better a11y story so
should surface the other big part of that in our examples/codegen.
@zpao zpao added this to the 4.0.0 milestone Oct 29, 2023
@zpao zpao merged commit 1d58905 into trunk Oct 29, 2023
16 checks passed
zpao added a commit that referenced this pull request Oct 29, 2023
Missed adding this after #283. With #321 we have a better a11y story so
should surface the other big part of that in our examples/codegen.
@zpao zpao deleted the a11y-svg-role branch May 16, 2024 01:21
@zpao zpao linked an issue Aug 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Accessibility support
1 participant