Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改了之前pr中的错误,并在上次pr后发现了一些其他的问题 #12

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ZZPHUB
Copy link

@ZZPHUB ZZPHUB commented Dec 6, 2023

  • /src/sing_step/art_heat.f90 中的人工热量计算的实现方式似乎也和公式不符合
  • /src/sign_step/art_visc.f90 中开头的注释中c是声速还是温度存疑。
  • 其他是修改pr中的内容或者是添加一些便于理解的注释
  • 在doc中添加了以目录分类的源文件内容简述,希望也能帮助理解代码结构。


!> 温度 ?
!> temperature ?
!> !!!!!!!!!!!!!!!!!!!!!!!!!!!!!教材中说c是声速!!!!!!!!!!!!!!!!!!!!!!!!!
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,应该是写错了,声速是对的

@zoziha
Copy link
Owner

zoziha commented Dec 6, 2023

  • /src/sing_step/art_heat.f90 中的人工热量计算的实现方式似乎也和公式不符合

好的,感谢标明

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants