Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account leap seconds in AUX messages' timestamps #691

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

ifakhrutdinov
Copy link
Contributor

@ifakhrutdinov ifakhrutdinov commented Mar 4, 2024

Proposed changes

The PR adds code to get the current amount of leap seconds and subtract that from the STCK value which goes into the timestamps.

Additional changes:

  • Pick up the cross-memory changes in zowe-common-c
  • Update the changelog with these changes

This PR addresses Issue: #690

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings

Testing

  • Start ZIS with AUX;
  • Compare the timestamps from the beginning of the JES and SYSPRINT logs; the timestamps should match.

@ifakhrutdinov ifakhrutdinov self-assigned this Mar 4, 2024
@ifakhrutdinov ifakhrutdinov force-pushed the bugfix/leap-seconds-in-zis-aux-msg branch 2 times, most recently from 5ed1c5b to 5093ae5 Compare March 4, 2024 16:19
@ifakhrutdinov ifakhrutdinov added the bug Something isn't working label Mar 4, 2024
@ifakhrutdinov ifakhrutdinov force-pushed the bugfix/leap-seconds-in-zis-aux-msg branch from 5093ae5 to 8a8fd50 Compare March 6, 2024 16:18
Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@JoeNemo JoeNemo merged commit b16b8d0 into v2.x/staging Mar 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants