-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for tls1.3 #646
support for tls1.3 #646
Conversation
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
@jordanfilteau1995 are you ready to merge? |
@JoeNemo I need Sean to sign off on leaving the "string" based cipher override for now because I don't have time to do the "english" to "openssl cipher enum" converter and global cipher override. |
I made it so you can change if needed, but it shouldn't. There aren't many supported ciphers for TLSv1.3. |
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this directly (GET /plugins) and indirectly (login to desktop with sso and access the editor) and saw both that tls 1.3 was being used, and that i saw no regressions.
Making ciphers and keyshares configurable.