Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for tls1.3 #646

Merged
merged 6 commits into from
Oct 10, 2023
Merged

support for tls1.3 #646

merged 6 commits into from
Oct 10, 2023

Conversation

jordanfilteau1995
Copy link
Contributor

@jordanfilteau1995 jordanfilteau1995 commented Sep 18, 2023

Making ciphers and keyshares configurable.

Signed-off-by: Jordan Filteau <[email protected]>
@JoeNemo
Copy link
Contributor

JoeNemo commented Sep 27, 2023

@jordanfilteau1995 are you ready to merge?

@jordanfilteau1995
Copy link
Contributor Author

@JoeNemo I need Sean to sign off on leaving the "string" based cipher override for now because I don't have time to do the "english" to "openssl cipher enum" converter and global cipher override.

@jordanfilteau1995
Copy link
Contributor Author

I made it so you can change if needed, but it shouldn't. There aren't many supported ciphers for TLSv1.3.

@jordanfilteau1995 jordanfilteau1995 changed the title [wip] support for tls1.3 support for tls1.3 Oct 10, 2023
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this directly (GET /plugins) and indirectly (login to desktop with sso and access the editor) and saw both that tls 1.3 was being used, and that i saw no regressions.

@1000TurquoisePogs 1000TurquoisePogs merged commit dbfe158 into v2.x/staging Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants