-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
z/OSMF static definition file processing #4113
base: v3.x/staging
Are you sure you want to change the base?
Conversation
Signed-off-by: Pablo Carle <[email protected]>
build 6636 SUCCEEDED. |
Test workflow 5847 is started. |
bin/libs/component.ts
Outdated
@@ -418,6 +418,22 @@ export function processComponentApimlStaticDefinitions(componentDir: string): bo | |||
|
|||
const contents = xplatform.loadFileUTF8(path,xplatform.AUTO_DETECT); | |||
if (contents) { | |||
const zosmfScheme = std.getenv("ZOSMF_SCHEME"); | |||
const attls = std.getenv("ZWE_zowe_network_client_tls_attls"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work for configs where people have recommended enabling attls through only the server variable.
It would be better to say if the client variable isn't defined, to use the server variable's value.
Something like we do here:
https://github.com/zowe/zlux-server-framework/blob/v3.x/staging/lib/util.js#L510-L520
Signed-off-by: Pablo Carle <[email protected]>
build 6659 FAILED. |
1 similar comment
build 6659 FAILED. |
PR type
Changes proposed in this PR
Include logic to determine if connections from API ML components to z/OSMF are made using https (default) or HTTP (when outbound AT-TLS rules are in place)
Does this PR introduce a breaking change?