Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate VSAM storage option in v3 #3969

Merged
merged 12 commits into from
Sep 5, 2024
Merged

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Sep 2, 2024

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Fixes

Changes proposed in this PR

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?


  • Affected function: general area of interest *

  • Description: 1 line description *

  • Part: name of customizable file involved *

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

Copy link

github-actions bot commented Sep 2, 2024

build 5879 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10666407176

Copy link

github-actions bot commented Sep 2, 2024

build 5881 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10667089771

Copy link

github-actions bot commented Sep 2, 2024

build 5882 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10667182744

Signed-off-by: ac892247 <[email protected]>
Copy link

github-actions bot commented Sep 2, 2024

build 5884 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10668100750

@achmelo achmelo requested a review from muzikovam September 4, 2024 08:50
Copy link

github-actions bot commented Sep 4, 2024

build 5907 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10698317279

Copy link
Contributor

@muzikovam muzikovam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small changes

workflows/files/ZWECONF.xml Show resolved Hide resolved
workflows/files/ZWECONF.properties Show resolved Hide resolved
@Martin-Zeithaml
Copy link
Contributor

And what about zwe init vsam command + VSAM samples + schema?

@achmelo
Copy link
Member Author

achmelo commented Sep 4, 2024

And what about zwe init vsam command + VSAM samples + schema?

It will remain available in v3 so we don't need to change anything in samples and schema. It may be a good idea to print some message in the zwe init vsam but I am not sure where would be the best place. Do you have a suggestion?

@Martin-Zeithaml
Copy link
Contributor

And what about zwe init vsam command + VSAM samples + schema?

It will remain available in v3 so we don't need to change anything in samples and schema. It may be a good idea to print some message in the zwe init vsam but I am not sure where would be the best place. Do you have a suggestion?

Ok, make sense, the zwe init vsam is already skipped if not VSAM. The command could stay the same. Maybe we can state some suggestion in help: VSAM is deprecated, consider using infinispan because...

Signed-off-by: ac892247 <[email protected]>
Copy link

github-actions bot commented Sep 4, 2024

build 5913 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10702419533

Copy link

github-actions bot commented Sep 5, 2024

build 5932 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10718986099

Copy link

github-actions bot commented Sep 5, 2024

Test workflow 5304 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3969/zowe-3.0.0-pr-3969-5932-20240905110017.pax
Running on machine: zzow07
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10719059363

@MarkAckert
Copy link
Member

There's an error during zowe startup in the integration test:

 ZWESVUSR WARN ZWEL0066W command 'ZWE_zowe_runtimeDirectory="/redacted" ZWE_CLI_PARAMETER_HA_INSTANCE="redacted_ha" ZWED_SSH_PORT="00" ZWED_TN3270_PORT="00" _CEE_RUNOPTS="HEAPPOOLS(OFF),HEAPPOOLS64(OFF)" _EDC_UMASK_DFLT="0002" CONFIG="/redacted.yaml" _BPXK_AUTOCVT="ON" ROOT_DIR="/redact" ZWE_CLI_PARAMETER_CONFIG="/redacted.yaml" /redacted/bin/utils/configmgr -script /redacted/bin/commands/internal/start/prepare/cli.js 2>&1' ended with code 256

<ZWELNCH:16842890> ZWESVUSR ERROR ZWEL0030E failed to prepare Zowe instance

Copy link

github-actions bot commented Sep 5, 2024

build 5938 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10721599610

Copy link

github-actions bot commented Sep 5, 2024

Test workflow 5309 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3969/zowe-3.0.0-pr-3969-5938-20240905134935.pax
Running on machine: zzow06
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10721744512

Copy link

github-actions bot commented Sep 5, 2024

build 5942 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10724757752

Copy link

github-actions bot commented Sep 5, 2024

Test workflow 5314 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3969/zowe-3.0.0-pr-3969-5942-20240905170059.pax
Running on machine: zzow07
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10724852087

@MarkAckert MarkAckert added the Build: None Used in CI label Sep 5, 2024
@MarkAckert MarkAckert merged commit 01ad229 into v3.x/staging Sep 5, 2024
7 checks passed
@MarkAckert MarkAckert deleted the v3-deprecate-vsam branch September 5, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build: None Used in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants