Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZWEGEN00 split CONFIG entry over multiple lines #3873

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

1000TurquoisePogs
Copy link
Member

Current JCL branch can leave CONFIG entry of ZWESLSTC without template resolution if the configuration length exceeds jcl line length.

This PR attempts to correct it by using some rexx to process ZWESLSTC deliberately for splitting the config the way we want.

CONFIG= works like this

one entry:
CONFIG=FILE(/foo)

multiple entries:
CONFIG=FILE(/foo):
FILE(/foo2):
FILE(/foo3)

Additionally, I saw the opportunity to force "defaults.yaml" into the config reading.
It should not end up in the CONFIG= output, but should be considered during the template resolution.
To add it, I detect runtimeDirectory via finding that in the first line of the schema entries, since they must be in the runtime directory.

Copy link

github-actions bot commented Jun 25, 2024

build 5491 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9663347192

Copy link

github-actions bot commented Jun 25, 2024

Test workflow 4833 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3873/zowe-2.16.0-pr-3873-5491-20240625133157.pax
Running on machine: zzow07
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9663460342

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Jun 26, 2024

build 5495 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9678549864

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Jun 26, 2024

build 5496 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9678602013

Copy link

github-actions bot commented Jun 26, 2024

Test workflow 4839 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3873/zowe-2.16.0-pr-3873-5495-20240626111620.pax
Running on machine: zzow08
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9678644676

Copy link

github-actions bot commented Jun 26, 2024

Test workflow 4840 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3873/zowe-2.16.0-pr-3873-5496-20240626112203.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9678725869

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
@1000TurquoisePogs
Copy link
Member Author

Merge back into main branch

Copy link

github-actions bot commented Jun 26, 2024

build 5497 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9679356309

@1000TurquoisePogs 1000TurquoisePogs merged commit 9188de0 into feature/v3/jcl Jun 26, 2024
6 checks passed
@1000TurquoisePogs 1000TurquoisePogs deleted the feature/v3/jcl-config-entry branch June 26, 2024 12:12
Copy link

github-actions bot commented Jun 26, 2024

build 5498 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9679372122

MarkAckert pushed a commit that referenced this pull request Dec 11, 2024
* WIP to have ZWEGEN00 split CONFIG entry over multiple lines.

Signed-off-by: 1000TurquoisePogs <[email protected]>

* Update CONFIG= for launcher

Signed-off-by: Martin Zeithaml <[email protected]>

* Simplify macro

Signed-off-by: Martin Zeithaml <[email protected]>

* Update SMPMCS.txt

Signed-off-by: 1000TurquoisePogs <[email protected]>

* Update SMPMCS.txt

Signed-off-by: 1000TurquoisePogs <[email protected]>

---------

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Martin Zeithaml <[email protected]>
Co-authored-by: Martin Zeithaml <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants