Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning internal return code through function argument for 'httpClientSessionInit' #469

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Gautham-coder
Copy link
Contributor

Proposed changes

Function 'httpClientSessionInit' calls other functions inside it and the return codes for those calls are not availabe outside 'httpClientSessionInit'. Adding a return code as argument will solve this requirement.

This PR addresses Issue: #468

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to version the API

@Gautham-coder
Copy link
Contributor Author

Sure Joe. Thanks

@Gautham-coder Gautham-coder force-pushed the httpClientSessionInit-internal-rc branch from d5842c4 to 559f281 Compare August 27, 2024 20:16
@Gautham-coder Gautham-coder force-pushed the httpClientSessionInit-internal-rc branch from 559f281 to a2dca1d Compare August 28, 2024 03:56
Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@JoeNemo JoeNemo merged commit 8baa40d into v2.x/staging Aug 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants