Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for longer cross-memory server parms #457

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ifakhrutdinov
Copy link
Contributor

@ifakhrutdinov ifakhrutdinov commented Jun 12, 2024

Proposed changes

This PR extends the standard cross-memory server's service responsible for accessing configuration parameters and related data structures to allow it to handle PARMLIB parameter keys and values longer than 128 characters.

This PR addresses Issue: zowe/zss#684

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • [x My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Regression testing

Existing short parameters should work as usual.

Support of long parameters testing:

To test long parameters, specify something like this in the ZIS PARMLIB member:

LONG_TEST_PARM=\
this_is_line_value_0123456789_0\
this_is_line_value_0123456789_1\
this_is_line_value_0123456789_2\
this_is_line_value_0123456789_3\
this_is_line_value_0123456789_4\
this_is_line_value_0123456789_5\
this_is_line_value_0123456789_6\
this_is_line_value_0123456789_7\
this_is_line_value_0123456789_8\
this_is_line_value_0123456789_9\
this_is_line_value_0123456789_10\
this_is_line_value_0123456789_11\
this_is_line_value_0123456789_12\
this_is_line_value_0123456789_13\
this_is_line_value_0123456789_14\
this_is_line_value_0123456789_15\
this_is_line_value_0123456789_16\
this_is_line_value_0123456789_17\
this_is_line_value_0123456789_18\
this_is_line_value_0123456789_19\
this_is_line_value_0123456789_20\
this_is_line_value_0123456789_21\
this_is_line_value_0123456789_22\
this_is_line_value_0123456789_23\
this_is_line_value_0123456789_24\
this_is_line_value_0123456789_25\
this_is_line_value_0123456789_26\
this_is_line_value_0123456789_27\
this_is_line_value_0123456789_28\
this_is_line_value_0123456789_29\
this_is_line_value_0123456789_30\
this_is_line_value_0123456789_31\
this_is_line_value_0123456789_32\
this_is_line_value_0123456789_33\
this_is_line_value_0123456789_34\
this_is_line_value_0123456789_35\
this_is_line_value_0123456789_36\
this_is_line_value_0123456789_37\
this_is_line_value_0123456789_38\
this_is_line_value_0123456789_39\
end

Without the fix, ZIS should terminate with an error on start-up and it must successfully start with the fix.

Further comments

@ifakhrutdinov ifakhrutdinov added the bug Something isn't working label Jun 12, 2024
@ifakhrutdinov ifakhrutdinov self-assigned this Jun 12, 2024
@ifakhrutdinov ifakhrutdinov force-pushed the bugfix/long-parm-support branch from eb22150 to 6018c98 Compare June 12, 2024 14:41
@ifakhrutdinov ifakhrutdinov force-pushed the bugfix/long-parm-support branch 2 times, most recently from ee1b58f to a90b2df Compare August 21, 2024 18:27
This commit extends the config cross-memory service and cross-memory
server's structures responsible for storing parameters to support
parameter names and values longer than 72 and 128 characters
respectively. Backward compatibility is provided by introducing and
using a version field in the config service's parameter list.

Fixes: zowe/zss#684

Signed-off-by: Irek Fakhrutdinov <[email protected]>
@ifakhrutdinov ifakhrutdinov force-pushed the bugfix/long-parm-support branch from a90b2df to 488a8e9 Compare August 22, 2024 15:24
@JoeNemo JoeNemo merged commit 02bd07f into v2.x/staging Aug 22, 2024
9 checks passed
@ifakhrutdinov ifakhrutdinov deleted the bugfix/long-parm-support branch August 22, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants