-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move WTO code from metal.c to zos.c + add shim #391
Conversation
Signed-off-by: Leanid Astrakou <[email protected]>
Have not tried removing it from metal.c completely yet, pending discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should define these functions in the zos.h file
But also, they need different names. zis uses both zos.c and metalio.c so same name will give conflict.
For now, wtoPrintf2 and message2 are fine, and we can adjust it after discussion later.
Signed-off-by: Leanid Astrakou <[email protected]>
wtoPrintf2 is already defined so using wtoPrintfMetal as a placeholder for now |
Signed-off-by: Leanid Astrakou <[email protected]>
…to feature/wto-syslog
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Leanid Astrakou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now lgtm
Signed-off-by: Leanid Astrakou <[email protected]>
Proposed changes
The WTO code should be moved from metal.c to zos.c because it works in both LE C & Metal C, and can therefore be used by components like the Launcher to print to the syslog critical Zowe messages
This PR depends upon the following PRs: zowe/launcher#93
zowe/zowe-install-packaging#3553
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments