-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect common env variables #347
Conversation
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 89.10% 89.09% -0.02%
==========================================
Files 65 65
Lines 3258 3255 -3
==========================================
- Hits 2903 2900 -3
Misses 355 355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, thanks for the fix Fernando!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: anaxceron <[email protected]>
Anax advanced usage
What It Does
Fixes #346.
Added support for commonly used environmental variables, like
REQUESTS_CA_BUNDLE
andCURL_CA_BUNDLE
How to Test
print((console.issue_command("D T"))['cmd-response'])
HTTPS_PROXY=https://myproxy.company.net:3129 python test.py
[SSL: CERTIFICATE_VERIFY_FAILED]
errorREQUESTS_CA_BUNDLE=/path/to/combo.crt
CURL_CA_BUNDLE=/path/to/combo.crt
combo.crt
refers to the complete certificate chain (proxyCA, intermediate/LPAR, global/root)Review Checklist
I certify that I have:
Additional Comments
The same can be achieved today using the
SSL_CERT_FILE
environmental variable