update readme #340

olamidepeterojo · 2024-10-20T14:44:15Z

What It Does
Updated typo in README
Consistent use of SDK name across SDKs

Fixes #326
Fixes #328
How to Test

Review Checklist
I certify that I have:

tested my changes
added/updated automated tests
updated the changelog
followed the contribution guidelines

Additional Comments

zFernand0

Hey @olamidepeterojo,
Please make sure to signoff your commits 😋

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin readme-update

codecov · 2024-10-21T13:28:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (385ee8c) to head (80a1520).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files          65       65           
  Lines        3258     3258           
=======================================
  Hits         2903     2903           
  Misses        355      355

Flag	Coverage Δ
unittests	`89.10% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

olamidepeterojo · 2024-10-21T15:03:32Z

Thank you for the kind gesture and efforts in going through my PR... Will do accordingly

Signed-off-by: Olamide Ojo <[email protected]>

zFernand0

LGTM! 😋

olamidepeterojo · 2024-10-25T14:29:59Z

Added the fix for this issue #328 to this PR

zFernand0

Thanks for updating the readme as well.

I see that license headers have Zowe Python Client SDK

For a quick fix, I suggest doing a find-and-replace with your IDE.

Otherwise, you may need to enhance the existing scripts/license_header.py script to account for license header updates 😓

zFernand0

LGTM 😋
just have one minor suggestion for the changelog entry for consistency 🙏

zFernand0 · 2024-10-28T14:47:40Z

CHANGELOG.md

+- Fixed the inconsistent use of the SDK name across SDKs in all files by implementing the "find and replace" tool
+- Therefore this fixes issue #328


Suggested change

- Fixed the inconsistent use of the SDK name across SDKs in all files by implementing the "find and replace" tool

- Therefore this fixes issue #328

- Fixed the inconsistent use of the SDK name across SDKs in all files by implementing the "find and replace" tool. [#328](https://github.com/zowe/zowe-client-python-sdk/issues/328)

okay, your suggestion is good, let me get it done right away

zFernand0 · 2024-10-28T15:06:17Z

CHANGELOG.md

 - Fixed exception handling in session.py [#213](https://github.com/zowe/zowe-client-python-sdk/issues/213)
+
+### Bug Fixes
+Fixed the inconsistent use of the SDK name across SDKs in all files by implementing the "find and replace" tool. [#328](https://github.com/zowe/zowe-client-python-sdk/issues/328)


Suggested change

- Fixed exception handling in session.py [#213](https://github.com/zowe/zowe-client-python-sdk/issues/213)

### Bug Fixes

Fixed the inconsistent use of the SDK name across SDKs in all files by implementing the "find and replace" tool. [#328](https://github.com/zowe/zowe-client-python-sdk/issues/328)

- Fixed exception handling in session.py [#213](https://github.com/zowe/zowe-client-python-sdk/issues/213)

- Fixed the inconsistent use of the SDK name across SDKs in all files by implementing the "find and replace" tool. [#328](https://github.com/zowe/zowe-client-python-sdk/issues/328)

Signed-off-by: Olamide Ojo <[email protected]>

zFernand0

Because of all the force-push, I'm unable to determine when the changelog entry was added in 1.0.0-dev.11 instead of the Recent Changes. 😢

Would you mind moving it to the very top?

## Recent Changes

### Enhancements

- Turning of logger at the class-constructor level [#316] (https://github.com/zowe/zowe-client-python-sdk/issues/316)

### Bug Fixes

- Fixed the inconsistent use of the SDK name across SDKs in all files by implementing the "find and replace" tool. [#328](https://github.com/zowe/zowe-client-python-sdk/issues/328)

## `1.0.0-dev21`

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

zFernand0

LGTM! 😋

olamidepeterojo · 2024-10-28T19:01:29Z

hey @zFernand0 , seems like you got it done already haha. would you still be needing i make the same changes?

zFernand0 · 2024-10-28T19:16:49Z

hey @zFernand0 , seems like you got it done already haha. would you still be needing i make the same changes?

Hey @olamidepeterojo,
I felt that I was being super annoying so that's why I tried to help out for once 😅
Apologies for all the requested changes...

And to answer you question, No.
I think there are no mo changes required/needed in order to get this PR merged in 🙏

Thanks for all the hard work 🙏

~~We just need one more review from the team before we get it merged 🥳~~
Apologies for the confusion... I thought we required more approvers

mering 😓

olamidepeterojo · 2024-10-28T21:26:11Z

its no hassle @zFernand0 its nice working with you and its my pleasure.

could you kindly check my PR of issue #336. ive been waiting your review haha.

zFernand0 closed this Oct 21, 2024

zFernand0 reopened this Oct 21, 2024

zFernand0 requested changes Oct 21, 2024

View reviewed changes

zFernand0 added the no-changelog label Oct 21, 2024

update readme

0b87d8b

Signed-off-by: Olamide Ojo <[email protected]>

olamidepeterojo force-pushed the readme-update branch from 5408903 to 0b87d8b Compare October 21, 2024 15:10

olamidepeterojo requested a review from zFernand0 October 21, 2024 15:55

zFernand0 approved these changes Oct 21, 2024

View reviewed changes

zFernand0 requested a review from t1m0thyj October 21, 2024 16:58

olamidepeterojo requested a review from zFernand0 October 26, 2024 17:37

zFernand0 requested changes Oct 28, 2024

View reviewed changes

olamidepeterojo force-pushed the readme-update branch from 7ed33f2 to 35f867c Compare October 28, 2024 14:40

olamidepeterojo requested a review from zFernand0 October 28, 2024 14:41

zFernand0 reviewed Oct 28, 2024

View reviewed changes

olamidepeterojo force-pushed the readme-update branch from 35f867c to cc2fd7a Compare October 28, 2024 14:52

olamidepeterojo requested a review from zFernand0 October 28, 2024 14:53

zFernand0 reviewed Oct 28, 2024

View reviewed changes

olamidepeterojo force-pushed the readme-update branch 2 times, most recently from 9639b8e to 6082793 Compare October 28, 2024 15:14

olamidepeterojo requested a review from zFernand0 October 28, 2024 15:14

Use the SDK name consistently

2bbd308

Signed-off-by: Olamide Ojo <[email protected]>

olamidepeterojo force-pushed the readme-update branch from 6082793 to 2bbd308 Compare October 28, 2024 15:16

zFernand0 requested changes Oct 28, 2024

View reviewed changes

chore: changelog update 😋

6909b9f

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

zFernand0 approved these changes Oct 28, 2024

View reviewed changes

Merge branch 'main' into readme-update

80a1520

zFernand0 requested review from gejohnston, awharn and traeok October 28, 2024 19:17

zFernand0 merged commit c4e23ef into zowe:main Oct 28, 2024
33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update readme #340

update readme #340

olamidepeterojo commented Oct 20, 2024 •

edited

Loading

zFernand0 left a comment •

edited

Loading

codecov bot commented Oct 21, 2024 •

edited

Loading

olamidepeterojo commented Oct 21, 2024

zFernand0 left a comment

olamidepeterojo commented Oct 25, 2024

zFernand0 left a comment

zFernand0 left a comment

zFernand0 Oct 28, 2024

olamidepeterojo Oct 28, 2024

zFernand0 Oct 28, 2024

zFernand0 left a comment

zFernand0 left a comment

olamidepeterojo commented Oct 28, 2024

zFernand0 commented Oct 28, 2024 •

edited

Loading

olamidepeterojo commented Oct 28, 2024

		- Fixed the inconsistent use of the SDK name across SDKs in all files by implementing the "find and replace" tool
		- Therefore this fixes issue #328

update readme #340

update readme #340

Conversation

olamidepeterojo commented Oct 20, 2024 • edited Loading

zFernand0 left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Oct 21, 2024 • edited Loading

Codecov Report

olamidepeterojo commented Oct 21, 2024

zFernand0 left a comment

Choose a reason for hiding this comment

olamidepeterojo commented Oct 25, 2024

zFernand0 left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

zFernand0 Oct 28, 2024

Choose a reason for hiding this comment

olamidepeterojo Oct 28, 2024

Choose a reason for hiding this comment

zFernand0 Oct 28, 2024

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

olamidepeterojo commented Oct 28, 2024

zFernand0 commented Oct 28, 2024 • edited Loading

olamidepeterojo commented Oct 28, 2024

olamidepeterojo commented Oct 20, 2024 •

edited

Loading

zFernand0 left a comment •

edited

Loading

codecov bot commented Oct 21, 2024 •

edited

Loading

zFernand0 commented Oct 28, 2024 •

edited

Loading