-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update REST API response type #322
Conversation
Signed-off-by: pem70 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 89.90% 89.05% -0.85%
==========================================
Files 53 65 +12
Lines 2813 3244 +431
==========================================
+ Hits 2529 2889 +360
- Misses 284 355 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far! 😋
Noticed a few untouched lines, mostly around the getitem and setitem, but I assume that's just because of how most unit tests might be referencing properties using dot notation as oposed to bracket notation (or vice-versa) 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @pem70 for adding all these return types 😍
src/zos_console/zowe/zos_console_for_zowe_sdk/response/console.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Timothy Johnson <[email protected]> Signed-off-by: Peizhao Mei <[email protected]>
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks Peizhao for adding these types!
|
||
# Assert that the first item in the list has the expected attributes defined | ||
attributes = first_item.keys() | ||
attributes = dir(first_item) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice if we implemented standard dictionary methods like .keys
, .values
etc on our response data classes, but this could be done as a future enhancement 😋
Release failed for the
Check the workflow run for more error details. Powered by Octorelease 🚀 |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Addresses [#89]
How to Test
Review Checklist
I certify that I have:
Additional Comments