Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create #304

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Update create #304

merged 5 commits into from
Jul 8, 2024

Conversation

pem70
Copy link
Collaborator

@pem70 pem70 commented Jul 2, 2024

What It Does
Fixes [#295]

How to Test

Review Checklist
I certify that I have:

Additional Comments
This is a temporary workaround since the error is not rooted in the Python SDK itself.

pem70 added 2 commits July 2, 2024 11:17
Signed-off-by: pem70 <[email protected]>
Signed-off-by: pem70 <[email protected]>
@pem70 pem70 requested review from t1m0thyj, zFernand0 and traeok July 2, 2024 15:22
@pem70 pem70 self-assigned this Jul 2, 2024
pem70 added 2 commits July 2, 2024 13:07
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.82%. Comparing base (a9cebff) to head (017549f).
Report is 162 commits behind head on main.

Files with missing lines Patch % Lines
.../zos_files/zowe/zos_files_for_zowe_sdk/datasets.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   89.81%   89.82%   +0.01%     
==========================================
  Files          53       53              
  Lines        2681     2694      +13     
==========================================
+ Hits         2408     2420      +12     
- Misses        273      274       +1     
Flag Coverage Δ
unittests 89.82% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pem70 pem70 marked this pull request as ready for review July 2, 2024 17:14
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! 🥳
LGTM! 😋
image

@zFernand0 zFernand0 linked an issue Jul 8, 2024 that may be closed by this pull request
@zFernand0 zFernand0 merged commit a903f49 into main Jul 8, 2024
21 checks passed
@zFernand0 zFernand0 deleted the Allocate-like branch July 8, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allocate-like does not use the same block-size as the source dataset
2 participants