-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/correlator issue 242 #246
Conversation
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 83.79% 83.75% -0.04%
==========================================
Files 34 34
Lines 2117 2118 +1
==========================================
Hits 1774 1774
- Misses 343 344 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: samadpls <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit hard to test personally since no matter the correlator, I always get no jobs back.
I do see how not using the submitting user as the default owner might help though.
@tucker01, could you help verify that this quick fix works for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @samadpls! This matches the behavior of the Node.js SDK when no owner is passed in.
What It Does
fixed #242
How to Test
Review Checklist
I certify that I have:
Additional Comments