Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/correlator issue 242 #246

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Fix/correlator issue 242 #246

merged 6 commits into from
Jan 9, 2024

Conversation

samadpls
Copy link
Contributor

@samadpls samadpls commented Dec 26, 2023

What It Does

fixed #242
How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7c11a84) 83.79% compared to head (ed19194) 83.75%.

Files Patch % Lines
src/zos_jobs/zowe/zos_jobs_for_zowe_sdk/jobs.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   83.79%   83.75%   -0.04%     
==========================================
  Files          34       34              
  Lines        2117     2118       +1     
==========================================
  Hits         1774     1774              
- Misses        343      344       +1     
Flag Coverage Δ
unittests 83.75% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JTonda JTonda requested a review from t1m0thyj January 3, 2024 16:11
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit hard to test personally since no matter the correlator, I always get no jobs back.
I do see how not using the submitting user as the default owner might help though.

@tucker01, could you help verify that this quick fix works for you?

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @samadpls! This matches the behavior of the Node.js SDK when no owner is passed in.

@zFernand0 zFernand0 merged commit c4e2a20 into main Jan 9, 2024
23 of 24 checks passed
@zFernand0 zFernand0 deleted the fix/correlator-issue-242 branch January 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zos-jobs] Listing by correlator doesn't work
3 participants