-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate that zowe.config.json file matches schema #192
Conversation
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
@t1m0thyj @zFernand0 I have created the PR this is currently incomplete. Need some reviews on it, and how we will handle/find the errors while doing validation 😊 |
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
…lidation errors Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
@t1m0thyj made some changes, please review it |
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
…ethod will be called automatically Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
props: dict = prof_manager.load(profile_name="zosmf", validate_schema=True) | ||
|
||
@patch("keyring.get_password", side_effect=keyring_get_password) | ||
def test_profile_loading_with_invalid_schema_internet_URI(self, get_pass_func): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added test for SchemaError
with InternetURI
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing earlier comments, validating schema works for me now with a global team config file in home dir 👍
Left a few comments on config_file.py. Once those are addressed I'll approve since coverage looks good as well 🙂
Signed-off-by: Aaditya Sinha <75474786+aadityasinha-dotcom@users.noreply.github.com>
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM!
left a few comments, not a huge deal though 😋
still going through the tests to see what's happening 😋
I tested this locally, it was working fine though 🤔 |
Signed-off-by: aadityasinha-dotcom <aadityasinha009@gmail.com>
Signed-off-by: Aaditya Sinha <75474786+aadityasinha-dotcom@users.noreply.github.com>
@aadityasinha-dotcom For the
If you have any of those files present locally, can you try deleting them or moving them out of the way so that tests are running in a clean environment without config? |
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
What It Does
Resolves #74
How to Test
Review Checklist
I certify that I have:
Additional Comments