Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system test fix #2388

Merged
merged 2 commits into from
Dec 16, 2024
Merged

system test fix #2388

merged 2 commits into from
Dec 16, 2024

Conversation

jace-roell
Copy link
Contributor

@jace-roell jace-roell commented Dec 16, 2024

What It Does

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: jace-roell <[email protected]>
@jace-roell jace-roell self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (7657a23) to head (c2a618c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2388   +/-   ##
=======================================
  Coverage   91.27%   91.28%           
=======================================
  Files         638      638           
  Lines       18151    18155    +4     
  Branches     3881     3921   +40     
=======================================
+ Hits        16568    16572    +4     
  Misses       1582     1582           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jace-roell jace-roell marked this pull request as ready for review December 16, 2024 20:14
Copy link

📅 Suggested merge-by date: 12/30/2024

Signed-off-by: jace-roell <[email protected]>
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
54.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit 15783f3 into master Dec 16, 2024
20 of 21 checks passed
@zFernand0 zFernand0 deleted the api-response-sys-test-fix branch December 16, 2024 21:36
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants