Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying a PDS into existing PDS w/ no members #2386

Merged
merged 18 commits into from
Dec 17, 2024
Merged

Conversation

pujal0909
Copy link
Contributor

@pujal0909 pujal0909 commented Dec 12, 2024

What It Does

The copy command now recognizes partitioned data sets. It can copy members of a source PDS into an existing target PDS w/ no members and displays an error if the source PDS has 0 members.
#2349

How to Test

Run the copy data set command with partitioned data sets.
zowe zos-files copy data-set "test-pds1" "test-pds2"

Review Checklist
I certify that I have:

Additional Comments

@pujal0909 pujal0909 changed the title updated copy pds functionality and system tests Copying a PDS into existing PDS w/ no members Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.26%. Comparing base (7657a23) to head (903fa30).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
packages/zosfiles/src/methods/copy/Copy.ts 86.11% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2386      +/-   ##
==========================================
- Coverage   91.27%   91.26%   -0.02%     
==========================================
  Files         638      638              
  Lines       18151    18186      +35     
  Branches     3881     3883       +2     
==========================================
+ Hits        16568    16598      +30     
- Misses       1582     1587       +5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pujal0909 pujal0909 marked this pull request as ready for review December 13, 2024 15:04
@pujal0909 pujal0909 requested a review from zFernand0 December 13, 2024 15:04
Copy link

📅 Suggested merge-by date: 12/27/2024

@adam-wolfe
Copy link
Contributor

Functionality LGTM. Will let others review.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this Pujal! I left a comment about handling PDSEs, but other than that everything LGTM

packages/zosfiles/src/methods/copy/Copy.ts Outdated Show resolved Hide resolved
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will approve once Trae's comment is addressed 🙏

packages/zosfiles/src/methods/copy/Copy.ts Outdated Show resolved Hide resolved
packages/zosfiles/src/methods/copy/Copy.ts Show resolved Hide resolved
packages/zosfiles/src/methods/copy/Copy.ts Outdated Show resolved Hide resolved
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked a question about what kind of error the user might get. Unless the answer to that question surprises us horribly, I approve.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the text help 🙏

However, that caused a few snapshots to fail.
Also, there is a small merge conflict in the changelog file which needs to be addressed when updating from master 😋

Once those items are addressed, I'm good to approve 🙏

Signed-off-by: Pujal <[email protected]>
@pujal0909 pujal0909 closed this Dec 16, 2024
@pujal0909 pujal0909 reopened this Dec 16, 2024
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changelogs @pujal0909!

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks for addressing feedback! 😁

packages/zosfiles/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Pujal Gandhi <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit a0b45a0 into master Dec 17, 2024
21 checks passed
@zFernand0 zFernand0 deleted the copy-pds-enhancement branch December 17, 2024 14:11
@zFernand0
Copy link
Member

Labeling release-current until EoD in case other related PRs are merged 🙏

@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants