-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copying a PDS into existing PDS w/ no members #2386
Conversation
Signed-off-by: Pujal <[email protected]>
packages/zosfiles/__tests__/__system__/methods/copy/Copy.system.test.ts
Dismissed
Show dismissed
Hide dismissed
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2386 +/- ##
==========================================
- Coverage 91.27% 91.26% -0.02%
==========================================
Files 638 638
Lines 18151 18186 +35
Branches 3881 3883 +2
==========================================
+ Hits 16568 16598 +30
- Misses 1582 1587 +5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts
Dismissed
Show dismissed
Hide dismissed
packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts
Dismissed
Show dismissed
Hide dismissed
packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts
Dismissed
Show dismissed
Hide dismissed
📅 Suggested merge-by date: 12/27/2024 |
Functionality LGTM. Will let others review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this Pujal! I left a comment about handling PDSEs, but other than that everything LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will approve once Trae's comment is addressed 🙏
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked a question about what kind of error the user might get. Unless the answer to that question surprises us horribly, I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the text help 🙏
However, that caused a few snapshots to fail.
Also, there is a small merge conflict in the changelog file which needs to be addressed when updating from master 😋
Once those items are addressed, I'm good to approve 🙏
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changelogs @pujal0909!
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal Gandhi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks for addressing feedback! 😁
Co-authored-by: Trae Yelovich <[email protected]> Signed-off-by: Pujal Gandhi <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Labeling |
What It Does
The copy command now recognizes partitioned data sets. It can copy members of a source PDS into an existing target PDS w/ no members and displays an error if the source PDS has 0 members.
#2349
How to Test
Run the copy data set command with partitioned data sets.
zowe zos-files copy data-set "test-pds1" "test-pds2"
Review Checklist
I certify that I have:
Additional Comments