Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first edits to ReadMe #2385

Merged
merged 11 commits into from
Dec 17, 2024
Merged

first edits to ReadMe #2385

merged 11 commits into from
Dec 17, 2024

Conversation

anaxceron
Copy link
Contributor

@anaxceron anaxceron commented Dec 11, 2024

What It Does
Addresses Issue 1820

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: anaxceron <[email protected]>
@anaxceron anaxceron added documentation cli release-current Indicates that there is no new functionality being delivered labels Dec 11, 2024
@anaxceron anaxceron self-assigned this Dec 11, 2024
@anaxceron anaxceron requested a review from zFernand0 December 11, 2024 19:54
Copy link

📅 Suggested merge-by date: 12/25/2024

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (15783f3) to head (ceb918f).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2385   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         638      638           
  Lines       18155    18155           
  Branches     3921     3885   -36     
=======================================
  Hits        16572    16572           
  Misses       1582     1582           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@anaxceron anaxceron linked an issue Dec 12, 2024 that may be closed by this pull request
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Left a few comments to consider, but overall, LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved

If you try to use Zowe CLI functionality and you get an error message that Zowe CLI failed to load any profiles, try issuing the following commands:

- `zowe config report-env` to generate a report on the status of the key areas in your working environment. Address any problems indicated in the report.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thank you for including multiple options! And for cleaning up this page in general :)

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @anaxceron

@zFernand0 zFernand0 added no-changelog and removed release-current Indicates that there is no new functionality being delivered labels Dec 17, 2024
@zFernand0 zFernand0 merged commit c42f9d4 into master Dec 17, 2024
17 checks passed
@zFernand0 zFernand0 deleted the anax-update-readme branch December 17, 2024 13:55
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli documentation no-changelog release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Still recommending v1 behavior in readme
4 participants