Attach authentication header to proxy agent

[rudyflores]

What It Does

Change the current way the authorization header is attached for the proxy request to instead be attached in the agent itself to avoid 403 error.

How to Test

In order to test this, use a proxy available that requires authentication and follow these setup steps:

1. In the proxy settings, define the url that requires authentication
2. In the proxy authorization setting click Edit in settings.json and replace the null property with the authentication type followed by space and the credentials in base64. Example: Basic ==MyBase64UserPassword. Note the credentials should use this pattern before encoding user:password

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (a0b45a0) to head (92aa324).
Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2382      +/-   ##
==========================================
+ Coverage   91.26%   91.28%   +0.01%     
==========================================
  Files         638      638              
  Lines       18190    18207      +17     
  Branches     3923     3930       +7     
==========================================
+ Hits        16602    16620      +18     
+ Misses       1587     1586       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zFernand0]

Hey @rudyflores,
The changes make sense to me 😋

Could you provide some steps to test it?
Also, could you update the changelog to capture this fix?

[traeok]

Changes LGTM, but looks like existing tests are failing in AbstractRestClient, so I'll approve once resolved. I also agree with Fernando's suggestion to have tests for this case - looks like they might just need moved and refactored. Thanks Rudy!

[rudyflores]

@zFernand0 @traeok instructions for testing this is on the PR readme now, currently working on the unit tests!

[rudyflores]

@traeok @zFernand0 FYI not sure why the CHANGELOG check is failing even after updating it...

[zFernand0]

Changes makes sense to me 🙏

left a suggestion to help fix the changelog check

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[traeok]

LGTM, thanks Rudy!

[zFernand0]

Overall, LGTM! 😋

I'm very curious about your prettier settings 😋
I don't mind the reformatting of the ProxySettings files, but I'm curious to know if people think we should enforce this sort of style going forward. 😋

[zFernand0]

labeled release-minor to combine the following PRs:

[github-actions]

Release succeeded for the master branch. 🎉

The following packages have been published:

• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]

_{Powered by Octorelease 🚀}