[v2] Download special char issue

[jace-roell]

What It Does
This PR resolves an issue where special characters could become corrupted when downloading large files. The corruption was caused by each chunk buffer being converted to a string when calling the processNewLines() function and then converted back to a buffer. This PR introduces support for passing buffers directly into the processNewLines() function to prevent corruption.

How to Test
The issue arises when a special character appears as the last character of a stream chunk. To reproduce, create a PDS file containing exclusively special characters with a size larger than the default chunk size (>8KB). In such cases, the last character of each chunk may be corrupted and appear as two unknown characters.

To observe this issue, download a PDS file that meets the criteria using the following example command (assuming the use of IBM-1147 encoding):

zowe zos-files download ds <PDSMEMBER> --encoding "IBM-1147"

where <PDSMEMBER> is a file larger than 8KB containing special characters.

Example Line (about 105 are required in a file to exceed 8KB):
àèéìòùÀÈÉÌÒÙ°àèéìòùÀÈÉÌÒÙ°àèéìòùÀÈÉÌÒÙ°àèéìòùÀÈÉÌÒÙ°àèéìòùÀÈÉÌÒÙ°àèéìòùÀÈÉÌÒÙ°à

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (4df8041) to head (fcb259a).
Report is 9 commits behind head on zowe-v2-lts.

Additional details and impacted files

@@              Coverage Diff              @@
##           zowe-v2-lts    #2362    +/-   ##
=============================================
  Coverage        91.24%   91.25%            
=============================================
  Files              638      638            
  Lines            19146    19158    +12     
  Branches          3943     4060   +117     
=============================================
+ Hits             17470    17482    +12     
  Misses            1675     1675            
  Partials             1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[traeok]

Thanks for porting 😋

[zFernand0]

I like how we are handling buffers in the processNewLines function.
Left a couple of comments, but I don't believe that they should stop this PR from being merged. 🙏

[zFernand0]

would it be possible to generate this file as part of the test resources, and remove after the test is done?

[zFernand0]

This works as expected 🙏

Wondering if we should fix the same issue for the upload operation 🙏

zdev files ul ftds ".../testfiles/specialCharTestData.txt" "fernando.test.ps001" --encoding "IBM-1147"

This could be handled in a separate PR, my apologies 🙏

[gejohnston]

Once Fernando's questions are resolved, I approve.

[zFernand0]

This works as expected 🙏

Wondering if we should fix the same issue for the upload operation 🙏

zdev files ul ftds ".../testfiles/specialCharTestData.txt" "fernando.test.ps001" --encoding "IBM-1147"

This was a Zowe Explorer issue.
The data on the mainframe looks good.
Once ZE adopts this version, it should be resolved there as well.

[zFernand0]

LGTM! 😋

Apologies for the oversight. Zowe Explorer still has the issue, but the data on the mainframe looks good 🙏

[github-actions]

Release succeeded for the zowe-v2-lts branch. 🎉

The following packages have been published:

• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]

_{Powered by Octorelease 🚀}