fix: require.main.filename check in DefaultCredentialManager

[traeok]

What It Does

In some environments (namely ESM and the Node.js REPL), the main property is not always available within the require object, so the if check for require.main.filename != null results in a TypeError.

How to Test

This one is a bit difficult to test, but this should work as an example:

• Make an empty folder and set up a basic NPM project using npm init

• Build a TGZ for @zowe/imperative using npm install && npm run build && npm pack in the packages/imperative folder. Install the generated tarball in this new NPM project alongside @zowe/secrets-for-zowe-sdk as normal dependencies:

  • npm install zowe-imperative-8.1.0.tgz @zowe/secrets-for-zowe-sdk

• Open the Node.js REPL within this folder: node -i

• Import DefaultCredentialManager within the REPL and create a new instance of it. Then attempt to initialize it. Initialization should be successful with no errors thrown:

  > const { DefaultCredentialManager } = await import("@zowe/imperative")
  > const credMgr = new DefaultCredentialManager()
  > await credMgr.initialize()

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (a8a90f8) to head (4279a63).
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2297   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         628      628           
  Lines       17867    17867           
  Branches     3735     3805   +70     
=======================================
  Hits        16271    16271           
  Misses       1595     1595           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[t1m0thyj]

LGTM, thanks @traeok!

[t1m0thyj]

Technically this changes the original behavior so that we always pass in a list of paths to require.resolve, but I don't think this change should be impactful 😋

[traeok]

This is a good point - I don't want to make any assumptions, and its possible that the default module resolution is special for certain projects. So, I've updated this to add optional chaining to the if check so that we only apply the paths if a filename is provided in require.main 😋 that way we keep the same behavior as before, but it still resolves the TypeError encountered in the attached issue.

[github-actions]

Release succeeded for the master branch. 🎉

The following packages have been published:

• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]

_{Powered by Octorelease 🚀}