-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fs-extra and jsonfile deps in Imperative #2264
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2264 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 638 638
Lines 19146 19146
Branches 4057 4058 +1
=======================================
Hits 17470 17470
Misses 1675 1675
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
86dbd74
to
3961dfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @t1m0thyj
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
jsonfile
dependency from v4 to v6. We should not be impacted by breaking changes, see changelog here.fs-extra
dependency from v8 (which depends onjsonfile@4
) to v9. See changelog here.serve
dev dep withhttp-server
which has fewer dependencies and none with vulnerabilties.How to Test
Review Checklist
I certify that I have:
Additional Comments