Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fs-extra and jsonfile deps in Imperative #2264

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

t1m0thyj
Copy link
Member

What It Does

  • Updates jsonfile dependency from v4 to v6. We should not be impacted by breaking changes, see changelog here.
  • Updates fs-extra dependency from v8 (which depends on jsonfile@4) to v9. See changelog here.
  • Replaces serve dev dep with http-server which has fewer dependencies and none with vulnerabilties.

How to Test

Review Checklist
I certify that I have:

Additional Comments

@t1m0thyj t1m0thyj marked this pull request as draft September 17, 2024 18:07
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (723ca5b) to head (3961dfb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2264   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         638      638           
  Lines       19146    19146           
  Branches     4057     4058    +1     
=======================================
  Hits        17470    17470           
  Misses       1675     1675           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj force-pushed the chore/update-jsonfile-dep branch from 86dbd74 to 3961dfb Compare September 17, 2024 18:12
@t1m0thyj t1m0thyj marked this pull request as ready for review September 17, 2024 18:32
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Copy link

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj

@zFernand0 zFernand0 merged commit 4265828 into master Sep 17, 2024
20 checks passed
@zFernand0 zFernand0 deleted the chore/update-jsonfile-dep branch September 17, 2024 20:37
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Sep 17, 2024
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants