Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Remove remaining references to V1 profiles #2239

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Aug 21, 2024

What It Does

Resolves #2231

Some classes have been deprecated, not yet removed. We should consider removing them in a future PR before V3 GA.

How to Test

Run CLI commands that load arguments from profiles to verify that CommandProcessor behavior has not broken.

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (29607bd) to head (4dba296).
Report is 11 commits behind head on next.

Files Patch % Lines
...ackages/imperative/src/cmd/src/CommandProcessor.ts 92.30% 3 Missing ⚠️
packages/imperative/src/utilities/src/CliUtils.ts 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2239      +/-   ##
==========================================
+ Coverage   91.22%   91.29%   +0.07%     
==========================================
  Files         632      632              
  Lines       18142    18126      -16     
  Branches     3779     3773       -6     
==========================================
- Hits        16550    16549       -1     
+ Misses       1591     1576      -15     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj linked an issue Aug 22, 2024 that may be closed by this pull request
Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj force-pushed the v3/remove-old-profiles branch from c2a4166 to 96723b6 Compare August 22, 2024 22:58
@t1m0thyj t1m0thyj marked this pull request as ready for review August 23, 2024 12:18
@t1m0thyj t1m0thyj requested a review from janan07 August 23, 2024 12:19
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks Timothy for removing these refs 😋

Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up these items. During previous rounds of change, I struggled to determine if such a large number of tests were testing behavior that was still needed.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Copy link

@zFernand0 zFernand0 merged commit 2f41f92 into next Aug 27, 2024
45 of 46 checks passed
@zFernand0 zFernand0 deleted the v3/remove-old-profiles branch August 27, 2024 12:53
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

[v3] Investigate removing IHandlerParameters.profiles
5 participants