-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Remove remaining references to V1 profiles #2239
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2239 +/- ##
==========================================
+ Coverage 91.22% 91.29% +0.07%
==========================================
Files 632 632
Lines 18142 18126 -16
Branches 3779 3773 -6
==========================================
- Hits 16550 16549 -1
+ Misses 1591 1576 -15
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
...s__/src/example_clis/with_bin_package/__integration__/ExampleDefinitions.integration.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
c2a4166
to
96723b6
Compare
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks Timothy for removing these refs 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up these items. During previous rounds of change, I struggled to determine if such a large number of tests were testing behavior that was still needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Signed-off-by: Timothy Johnson <[email protected]>
Quality Gate passedIssues Measures |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Resolves #2231
Some classes have been deprecated, not yet removed. We should consider removing them in a future PR before V3 GA.
How to Test
Run CLI commands that load arguments from profiles to verify that
CommandProcessor
behavior has not broken.Review Checklist
I certify that I have:
Additional Comments