Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Fail on error behavior #2221

Merged
merged 3 commits into from
Aug 13, 2024
Merged

[v1] Fail on error behavior #2221

merged 3 commits into from
Aug 13, 2024

Conversation

jace-roell
Copy link
Contributor

@jace-roell jace-roell commented Aug 7, 2024

modified plugins validate to default to fail when an error occurs. zowe plugins validate <plugin-name> behaves as zowe plugins validate <plugin-name> --fail-on-error

Review Checklist
I certify that I have:

Signed-off-by: jace-roell <[email protected]>
@jace-roell jace-roell changed the base branch from master to zowe-v1-lts August 7, 2024 19:53
@jace-roell jace-roell marked this pull request as ready for review August 8, 2024 13:38
@jace-roell jace-roell requested a review from zFernand0 August 8, 2024 13:38
@jace-roell jace-roell linked an issue Aug 9, 2024 that may be closed by this pull request
@jace-roell jace-roell requested a review from anaxceron August 12, 2024 14:35
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting minor edits.

packages/imperative/CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: jace-roell <[email protected]>
@jace-roell jace-roell requested a review from anaxceron August 12, 2024 17:45
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jace-roell!

Copy link

@awharn awharn merged commit 32408ff into zowe-v1-lts Aug 13, 2024
13 checks passed
@awharn awharn deleted the fail-on-error-behavior branch August 13, 2024 13:53
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Aug 13, 2024
Copy link

Release succeeded for the zowe-v1-lts branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

zowe plugins validate returns always RC=0
4 participants