-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display messages before prompting for properties #2123
Conversation
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2123 +/- ##
==========================================
+ Coverage 90.96% 90.98% +0.01%
==========================================
Files 618 618
Lines 17473 17484 +11
Branches 3600 3605 +5
==========================================
+ Hits 15895 15907 +12
+ Misses 1577 1576 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
"Some required connection properties have not been specified\n" + | ||
"in your Zowe client configuration." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
What's our stance on arbitrarily wrapping CLI output?
Maybe we can have a quick UX review on this? 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Gene!
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
...es/imperative/src/imperative/__tests__/config/cmd/auto-init/BaseAutoInitHandler.unit.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the TextUtils preferredWidth value with the terminal/process columns 😋
LGTM! 😋
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Display informative messages identifying why a user is being prompted for connection properties during a CLI command
How to Test
Create a situation where some connection properties are missing. Run a Zowe command. See the messages before the prompts.
Three scenarios exist in which messages are displayed.
Review Checklist
I certify that I have:
Additional Comments